Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the due date on invoices #40

Closed
wants to merge 4 commits into from

Conversation

@codevio
Copy link
Collaborator

codevio commented Nov 25, 2019

The due date can be editable on each invoice.
The due date can be set to null, so no due date appears on invoice.
The default due date is set to 3 months.

@codevio codevio mentioned this pull request Nov 25, 2019
codevio added 3 commits Nov 25, 2019
Adding multiple tax rates
@codevio

This comment has been minimized.

Copy link
Collaborator Author

codevio commented Nov 25, 2019

We should update readme to show how to change the due_date.

Copy link
Owner

ConsoleTVs left a comment

Polish need to be taken care. Lots of features should not be part of this PR and should be moved to: #41

*
* @var array
*/
public $tax_rates;

This comment has been minimized.

Copy link
@ConsoleTVs

ConsoleTVs Nov 25, 2019

Owner

What does this have to do with the due date feature?

$this->decimals = config('invoices.decimals');
$this->logo = config('invoices.logo');
$this->logo_height = config('invoices.logo_height');
$this->date = Carbon::now();
$this->business_details = Collection::make(config('invoices.business_details'));
$this->customer_details = Collection::make([]);
$this->footnote = config('invoices.footnote');
$this->tax_rates = config('invoices.tax_rates');

This comment has been minimized.

Copy link
@ConsoleTVs

ConsoleTVs Nov 25, 2019

Owner

What does this have to do with the due date feature?

| You can't mix percentage and fixed tax rates.
*/
'tax_rates' => [

This comment has been minimized.

Copy link
@ConsoleTVs

ConsoleTVs Nov 25, 2019

Owner

What does this have to do with the due date feature?

@@ -15,6 +15,9 @@
</div>
<div style="margin-left:300pt;">
<b>Date: </b> {{ $invoice->date->formatLocalized('%A %d %B %Y') }}<br />
@if ($invoice->due_date)
<b>Due date: </b>{{ $invoice->due_date->formatLocalized('%A %d %B %Y') }}<br />

This comment has been minimized.

Copy link
@ConsoleTVs

ConsoleTVs Nov 25, 2019

Owner

Looks OK

</td>
<td>{{ $invoice->taxPriceFormatted() }} {{ $invoice->formatCurrency()->symbol }}</td>
</tr>
@foreach($invoice->tax_rates as $tax_rate)

This comment has been minimized.

Copy link
@ConsoleTVs

ConsoleTVs Nov 25, 2019

Owner

What does this have to do with the due date feature?

$this->due_date = $due_date;
return $this;
}

This comment has been minimized.

Copy link
@ConsoleTVs

ConsoleTVs Nov 25, 2019

Owner

Looks great

@codevio

This comment has been minimized.

Copy link
Collaborator Author

codevio commented Nov 25, 2019

@ConsoleTVs Sorry, there is a bug with my branch.. I'll redo it.

@ConsoleTVs

This comment has been minimized.

Copy link
Owner

ConsoleTVs commented Nov 25, 2019

Not to worry! I'll be happy to accept it once it's fixed!

Thanks for your time

@codevio codevio closed this Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.