Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiple tax rates #43

Merged
merged 3 commits into from Nov 26, 2019

Conversation

@codevio
Copy link
Collaborator

codevio commented Nov 25, 2019

Created a new array with multiple tax rates.
Modified the function taxPrice to ajust the calcul for the Total or only for the Tax.
Cannot modify on each invoice individually.

We should remove unused function for setting the tax in a controller.
We should update readme.

@codevio codevio mentioned this pull request Nov 25, 2019
Copy link
Owner

ConsoleTVs left a comment

There appears to be merge conflicts and I can't merge it. I think it's due the mess up with the other PR.

@codevio

This comment has been minimized.

Copy link
Collaborator Author

codevio commented Nov 26, 2019

It's fix.

@ConsoleTVs ConsoleTVs merged commit 17d13b2 into ConsoleTVs:master Nov 26, 2019
1 check failed
1 check failed
continuous-integration/styleci/pr Issues have been identified with 3 files
Details
@ConsoleTVs

This comment has been minimized.

Copy link
Owner

ConsoleTVs commented Nov 26, 2019

That was quick!

@codevio I am very happy for both of your contributions.

I would ask you one more thing. As you pointed out, the docs should be updated.

https://github.com/ConsoleTVs/Invoices/blob/master/docs/1/readme.md

Just add a few lines as a reference of your work. After it's done, I will bump and make a new release of Invoices.

Thanks again for the hard work ;)

@codevio codevio deleted the codevio:tax_rates branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.