From e0fa6b3157460993579dadbb82627c99d5092e7f Mon Sep 17 00:00:00 2001 From: Jimmy Li Date: Thu, 30 Nov 2023 14:48:16 -0800 Subject: [PATCH] Fix num_results query param --- library/src/main/java/io/constructor/core/Constants.kt | 2 +- .../java/io/constructor/core/ConstructorIoIntegrationTest.kt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/library/src/main/java/io/constructor/core/Constants.kt b/library/src/main/java/io/constructor/core/Constants.kt index 8f1f1872..ae4473fb 100755 --- a/library/src/main/java/io/constructor/core/Constants.kt +++ b/library/src/main/java/io/constructor/core/Constants.kt @@ -50,7 +50,7 @@ class Constants { const val FILTER_VALUE = "filter_value" const val RESULT_POSITION_ON_PAGE = "result_position_on_page" const val RESULT_COUNT = "result_count" - const val NUM_RESULT = "num_result" + const val NUM_RESULT = "num_results" const val ITEM_ID = "item_id" const val IDS = "ids" const val TERM = "term" diff --git a/library/src/test/java/io/constructor/core/ConstructorIoIntegrationTest.kt b/library/src/test/java/io/constructor/core/ConstructorIoIntegrationTest.kt index 0d0d88a6..308d40f2 100644 --- a/library/src/test/java/io/constructor/core/ConstructorIoIntegrationTest.kt +++ b/library/src/test/java/io/constructor/core/ConstructorIoIntegrationTest.kt @@ -1058,13 +1058,14 @@ class ConstructorIoIntegrationTest { @Test fun getRecommendationResultsAgainstRealResponse() { val facet = hashMapOf("Brand" to listOf("XYZ")) - val observer = constructorIo.getRecommendationResults("home_page_1", facet.map { it.key to it.value }).test() + val observer = constructorIo.getRecommendationResults("home_page_1", facet.map { it.key to it.value }, 50).test() observer.assertComplete() observer.assertNoErrors() val recommendationResponse = observer.values()[0].get() assertTrue(recommendationResponse?.resultId !== null) assertTrue(recommendationResponse?.request!!.isNotEmpty()) + assertTrue(recommendationResponse?.request!!.get("num_results") == 50.0) assertTrue(recommendationResponse?.response?.pod !== null) assertTrue(recommendationResponse?.response?.results !== null) assertTrue(recommendationResponse?.response?.resultCount!! >= 0)