Skip to content

Fix issue with num_results query param #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix issue with num_results query param #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/src/main/java/io/constructor/core/Constants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class Constants {
const val FILTER_VALUE = "filter_value"
const val RESULT_POSITION_ON_PAGE = "result_position_on_page"
const val RESULT_COUNT = "result_count"
const val NUM_RESULT = "num_result"
const val NUM_RESULT = "num_results"
const val ITEM_ID = "item_id"
const val IDS = "ids"
const val TERM = "term"
Expand Down
3 changes: 2 additions & 1 deletion library/src/test/java/io/constructor/core/ConstructorIoIntegrationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,13 +1058,14 @@ class ConstructorIoIntegrationTest {
@Test
fun getRecommendationResultsAgainstRealResponse() {
val facet = hashMapOf("Brand" to listOf("XYZ"))
val observer = constructorIo.getRecommendationResults("home_page_1", facet.map { it.key to it.value }).test()
val observer = constructorIo.getRecommendationResults("home_page_1", facet.map { it.key to it.value }, 50).test()
observer.assertComplete()
observer.assertNoErrors()

val recommendationResponse = observer.values()[0].get()
assertTrue(recommendationResponse?.resultId !== null)
assertTrue(recommendationResponse?.request!!.isNotEmpty())
assertTrue(recommendationResponse?.request!!.get("num_results") == 50.0)
assertTrue(recommendationResponse?.response?.pod !== null)
assertTrue(recommendationResponse?.response?.results !== null)
assertTrue(recommendationResponse?.response?.resultCount!! >= 0)
Expand Down