From 2ee5e8592efc65dc384b45b1941d617f257c30d2 Mon Sep 17 00:00:00 2001 From: Tarek Ahmed Date: Tue, 28 Oct 2025 14:45:19 +0400 Subject: [PATCH 1/4] bump packages --- package-lock.json | 94 +++++++++++++++++++++++++++++++---------------- 1 file changed, 62 insertions(+), 32 deletions(-) diff --git a/package-lock.json b/package-lock.json index 2de013a7..dada0071 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9721,14 +9721,14 @@ } }, "node_modules/axios": { - "version": "1.9.0", - "resolved": "https://registry.npmjs.org/axios/-/axios-1.9.0.tgz", - "integrity": "sha512-re4CqKTJaURpzbLHtIi6XpDv20/CnpXOtjRY5/CU32L8gU8ek9UIivcfvSWvmKEngmVbrUtPpdDwWDWL7DNHvg==", + "version": "1.13.0", + "resolved": "https://registry.npmjs.org/axios/-/axios-1.13.0.tgz", + "integrity": "sha512-zt40Pz4zcRXra9CVV31KeyofwiNvAbJ5B6YPz9pMJ+yOSLikvPT4Yi5LjfgjRa9CawVYBaD1JQzIVcIvBejKeA==", "dev": true, "license": "MIT", "dependencies": { "follow-redirects": "^1.15.6", - "form-data": "^4.0.0", + "form-data": "^4.0.4", "proxy-from-env": "^1.1.0" } }, @@ -18943,31 +18943,50 @@ } }, "node_modules/playwright": { - "version": "1.29.2", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.29.2.tgz", - "integrity": "sha512-hKBYJUtdmYzcjdhYDkP9WGtORwwZBBKAW8+Lz7sr0ZMxtJr04ASXVzH5eBWtDkdb0c3LLFsehfPBTRfvlfKJOA==", + "version": "1.56.1", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.56.1.tgz", + "integrity": "sha512-aFi5B0WovBHTEvpM3DzXTUaeN6eN0qWnTkKx4NQaH4Wvcmc153PdaY2UBdSYKaGYw+UyWXSVyxDUg5DoPEttjw==", "dev": true, - "hasInstallScript": true, + "license": "Apache-2.0", "dependencies": { - "playwright-core": "1.29.2" + "playwright-core": "1.56.1" }, "bin": { "playwright": "cli.js" }, "engines": { - "node": ">=14" + "node": ">=18" + }, + "optionalDependencies": { + "fsevents": "2.3.2" } }, "node_modules/playwright-core": { - "version": "1.29.2", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.29.2.tgz", - "integrity": "sha512-94QXm4PMgFoHAhlCuoWyaBYKb92yOcGVHdQLoxQ7Wjlc7Flg4aC/jbFW7xMR52OfXMVkWicue4WXE7QEegbIRA==", + "version": "1.56.1", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.56.1.tgz", + "integrity": "sha512-hutraynyn31F+Bifme+Ps9Vq59hKuUCz7H1kDOcBs+2oGguKkWTU50bBWrtz34OUWmIwpBTWDxaRPXrIXkgvmQ==", "dev": true, + "license": "Apache-2.0", "bin": { - "playwright": "cli.js" + "playwright-core": "cli.js" }, "engines": { - "node": ">=14" + "node": ">=18" + } + }, + "node_modules/playwright/node_modules/fsevents": { + "version": "2.3.2", + "resolved": "https://registry.npmjs.org/fsevents/-/fsevents-2.3.2.tgz", + "integrity": "sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA==", + "dev": true, + "hasInstallScript": true, + "license": "MIT", + "optional": true, + "os": [ + "darwin" + ], + "engines": { + "node": "^8.16.0 || ^10.6.0 || >=11.0.0" } }, "node_modules/polished": { @@ -22269,10 +22288,11 @@ } }, "node_modules/vite": { - "version": "7.1.5", - "resolved": "https://registry.npmjs.org/vite/-/vite-7.1.5.tgz", - "integrity": "sha512-4cKBO9wR75r0BeIWWWId9XK9Lj6La5X846Zw9dFfzMRw38IlTk2iCcUt6hsyiDRcPidc55ZParFYDXi0nXOeLQ==", + "version": "7.1.12", + "resolved": "https://registry.npmjs.org/vite/-/vite-7.1.12.tgz", + "integrity": "sha512-ZWyE8YXEXqJrrSLvYgrRP7p62OziLW7xI5HYGWFzOvupfAlrLvURSzv/FyGyy0eidogEM3ujU+kUG1zuHgb6Ug==", "dev": true, + "license": "MIT", "dependencies": { "esbuild": "^0.25.0", "fdir": "^6.5.0", @@ -30349,13 +30369,13 @@ "dev": true }, "axios": { - "version": "1.9.0", - "resolved": "https://registry.npmjs.org/axios/-/axios-1.9.0.tgz", - "integrity": "sha512-re4CqKTJaURpzbLHtIi6XpDv20/CnpXOtjRY5/CU32L8gU8ek9UIivcfvSWvmKEngmVbrUtPpdDwWDWL7DNHvg==", + "version": "1.13.0", + "resolved": "https://registry.npmjs.org/axios/-/axios-1.13.0.tgz", + "integrity": "sha512-zt40Pz4zcRXra9CVV31KeyofwiNvAbJ5B6YPz9pMJ+yOSLikvPT4Yi5LjfgjRa9CawVYBaD1JQzIVcIvBejKeA==", "dev": true, "requires": { "follow-redirects": "^1.15.6", - "form-data": "^4.0.0", + "form-data": "^4.0.4", "proxy-from-env": "^1.1.0" } }, @@ -37283,18 +37303,28 @@ } }, "playwright": { - "version": "1.29.2", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.29.2.tgz", - "integrity": "sha512-hKBYJUtdmYzcjdhYDkP9WGtORwwZBBKAW8+Lz7sr0ZMxtJr04ASXVzH5eBWtDkdb0c3LLFsehfPBTRfvlfKJOA==", + "version": "1.56.1", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.56.1.tgz", + "integrity": "sha512-aFi5B0WovBHTEvpM3DzXTUaeN6eN0qWnTkKx4NQaH4Wvcmc153PdaY2UBdSYKaGYw+UyWXSVyxDUg5DoPEttjw==", "dev": true, "requires": { - "playwright-core": "1.29.2" + "fsevents": "2.3.2", + "playwright-core": "1.56.1" + }, + "dependencies": { + "fsevents": { + "version": "2.3.2", + "resolved": "https://registry.npmjs.org/fsevents/-/fsevents-2.3.2.tgz", + "integrity": "sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA==", + "dev": true, + "optional": true + } } }, "playwright-core": { - "version": "1.29.2", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.29.2.tgz", - "integrity": "sha512-94QXm4PMgFoHAhlCuoWyaBYKb92yOcGVHdQLoxQ7Wjlc7Flg4aC/jbFW7xMR52OfXMVkWicue4WXE7QEegbIRA==", + "version": "1.56.1", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.56.1.tgz", + "integrity": "sha512-hutraynyn31F+Bifme+Ps9Vq59hKuUCz7H1kDOcBs+2oGguKkWTU50bBWrtz34OUWmIwpBTWDxaRPXrIXkgvmQ==", "dev": true }, "polished": { @@ -39759,9 +39789,9 @@ "dev": true }, "vite": { - "version": "7.1.5", - "resolved": "https://registry.npmjs.org/vite/-/vite-7.1.5.tgz", - "integrity": "sha512-4cKBO9wR75r0BeIWWWId9XK9Lj6La5X846Zw9dFfzMRw38IlTk2iCcUt6hsyiDRcPidc55ZParFYDXi0nXOeLQ==", + "version": "7.1.12", + "resolved": "https://registry.npmjs.org/vite/-/vite-7.1.12.tgz", + "integrity": "sha512-ZWyE8YXEXqJrrSLvYgrRP7p62OziLW7xI5HYGWFzOvupfAlrLvURSzv/FyGyy0eidogEM3ujU+kUG1zuHgb6Ug==", "dev": true, "requires": { "esbuild": "^0.25.0", From 32eae031fd9c2ca0fe4e43834305830616eac14d Mon Sep 17 00:00:00 2001 From: Tarek Ahmed Date: Tue, 28 Oct 2025 16:34:41 +0400 Subject: [PATCH 2/4] Include playwright as a dev dependency --- package-lock.json | 1 + package.json | 1 + 2 files changed, 2 insertions(+) diff --git a/package-lock.json b/package-lock.json index dada0071..899ce0f4 100644 --- a/package-lock.json +++ b/package-lock.json @@ -48,6 +48,7 @@ "jest-environment-jsdom": "^29.7.0", "jest-fail-on-console": "^3.2.0", "license-checker": "^25.0.1", + "playwright": "^1.56.1", "react": "^18.2.0", "react-dom": "^18.2.0", "start-server-and-test": "^2.0.0", diff --git a/package.json b/package.json index 133631ac..4814c11f 100644 --- a/package.json +++ b/package.json @@ -106,6 +106,7 @@ "jest-environment-jsdom": "^29.7.0", "jest-fail-on-console": "^3.2.0", "license-checker": "^25.0.1", + "playwright": "^1.56.1", "react": "^18.2.0", "react-dom": "^18.2.0", "start-server-and-test": "^2.0.0", From c6c25c7a52bdd16fee9b1f8d8dab45a4a9fd0dcd Mon Sep 17 00:00:00 2001 From: Tarek Ahmed Date: Wed, 29 Oct 2025 00:03:14 +0400 Subject: [PATCH 3/4] Remove playwright as a dependancy, install playwright in the workflow --- .github/workflows/test-storybook.yml | 2 ++ package-lock.json | 1 - package.json | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-storybook.yml b/.github/workflows/test-storybook.yml index b768721d..f1622e90 100644 --- a/.github/workflows/test-storybook.yml +++ b/.github/workflows/test-storybook.yml @@ -20,5 +20,7 @@ jobs: node-version: '18.13.0' - name: Install dependencies run: npm ci + - name: Install Playwright browsers + run: npx playwright install - name: Run Tests run: npm run test-storybook:ci \ No newline at end of file diff --git a/package-lock.json b/package-lock.json index 899ce0f4..dada0071 100644 --- a/package-lock.json +++ b/package-lock.json @@ -48,7 +48,6 @@ "jest-environment-jsdom": "^29.7.0", "jest-fail-on-console": "^3.2.0", "license-checker": "^25.0.1", - "playwright": "^1.56.1", "react": "^18.2.0", "react-dom": "^18.2.0", "start-server-and-test": "^2.0.0", diff --git a/package.json b/package.json index 4814c11f..133631ac 100644 --- a/package.json +++ b/package.json @@ -106,7 +106,6 @@ "jest-environment-jsdom": "^29.7.0", "jest-fail-on-console": "^3.2.0", "license-checker": "^25.0.1", - "playwright": "^1.56.1", "react": "^18.2.0", "react-dom": "^18.2.0", "start-server-and-test": "^2.0.0", From e9956b1be9bf0bf81e26cb8dce556ec1cd8f2fa1 Mon Sep 17 00:00:00 2001 From: Tarek Ahmed Date: Wed, 29 Oct 2025 00:51:34 +0400 Subject: [PATCH 4/4] Remove unneeded eslint rule --- .eslintrc.json | 3 +-- package-lock.json | 16 ---------------- package.json | 1 - 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index be2a7e00..b9657c17 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -65,13 +65,12 @@ "jest": true, "jest/globals": true }, - "plugins": ["jest", "no-snapshot-testing", "testing-library"], + "plugins": ["jest", "testing-library"], "extends": ["plugin:jest/recommended", "plugin:testing-library/react"], "rules": { // https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/no-node-access.md "testing-library/no-node-access": ["error", { "allowContainerFirstChild": true }], // https://github.com/VicJer/eslint-plugin-no-snapshot-testing - "no-snapshot-testing/no-snapshot-testing": "error", "import/no-extraneous-dependencies": [ "error", { "devDependencies": true, "peerDependencies": true } diff --git a/package-lock.json b/package-lock.json index dada0071..27fae8c1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -36,7 +36,6 @@ "eslint-plugin-import": "^2.26.0", "eslint-plugin-jest": "^27.9.0", "eslint-plugin-jsx-a11y": "^6.7.1", - "eslint-plugin-no-snapshot-testing": "^1.0.61", "eslint-plugin-prettier": "^4.2.1", "eslint-plugin-react": "^7.31.11", "eslint-plugin-react-hooks": "^4.6.0", @@ -12794,15 +12793,6 @@ "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8" } }, - "node_modules/eslint-plugin-no-snapshot-testing": { - "version": "1.0.61", - "resolved": "https://registry.npmjs.org/eslint-plugin-no-snapshot-testing/-/eslint-plugin-no-snapshot-testing-1.0.61.tgz", - "integrity": "sha512-/O1sNPoJ+nPo4TemMkmdjCcNMLQy/HtXcG3bOlQLxcRbRk8xV3uE+1l3ltLTmz1d9KV8UI546YtrJKfjGsG7yg==", - "dev": true, - "engines": { - "node": ">=0.10.0" - } - }, "node_modules/eslint-plugin-prettier": { "version": "4.2.1", "resolved": "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-4.2.1.tgz", @@ -32716,12 +32706,6 @@ "semver": "^6.3.0" } }, - "eslint-plugin-no-snapshot-testing": { - "version": "1.0.61", - "resolved": "https://registry.npmjs.org/eslint-plugin-no-snapshot-testing/-/eslint-plugin-no-snapshot-testing-1.0.61.tgz", - "integrity": "sha512-/O1sNPoJ+nPo4TemMkmdjCcNMLQy/HtXcG3bOlQLxcRbRk8xV3uE+1l3ltLTmz1d9KV8UI546YtrJKfjGsG7yg==", - "dev": true - }, "eslint-plugin-prettier": { "version": "4.2.1", "resolved": "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-4.2.1.tgz", diff --git a/package.json b/package.json index 133631ac..c74389e2 100644 --- a/package.json +++ b/package.json @@ -94,7 +94,6 @@ "eslint-plugin-import": "^2.26.0", "eslint-plugin-jest": "^27.9.0", "eslint-plugin-jsx-a11y": "^6.7.1", - "eslint-plugin-no-snapshot-testing": "^1.0.61", "eslint-plugin-prettier": "^4.2.1", "eslint-plugin-react": "^7.31.11", "eslint-plugin-react-hooks": "^4.6.0",