Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update chproxy documentation design #213

Merged
merged 1 commit into from Aug 26, 2022
Merged

[docs] Update chproxy documentation design #213

merged 1 commit into from Aug 26, 2022

Conversation

pixelastic
Copy link
Contributor

@pixelastic pixelastic commented Aug 26, 2022

Description

This will update the design of the website, to include the new logo, and update colors accordingly.

Check this live here: https://chproxy-pr-213.onrender.com/

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Comparison

image
The current website

image
The new website

image
And mobile mode

Further comments

The website is built using Next v2, and more specifically the Nuxt Content plugin with the Nuxt Content Docs Theme. Those specific plugins and version seem to be no longer maintained (Nuxt is now on v3, and the Docs Theme has been officially deprecated).

This means that updating the theme colors required me to do some hacky CSS stuff, as the plugin itself doesn't allow for an easy way to change the colors (except the link colors). So I had to add my own custom CSS file, that artificially overwrite the selector of the various elements I wanted to change. Said element most of the time didn't have any semantic attribute to ease selection, so I had to use presentational attribute for some selectors. As I said, it's hacky.

Please let me know if you see any issues (like wrong colors, most probably default green showing up), and I'll fix them.

@render
Copy link

render bot commented Aug 26, 2022

@mga-chka mga-chka merged commit 61ad5cd into master Aug 26, 2022
@mga-chka mga-chka deleted the docs/design branch August 26, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants