New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alert boxes #135

Closed
dbads opened this Issue Oct 28, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@dbads
Copy link
Member

dbads commented Oct 28, 2018

currently there are alert boxes on success/failure of various actions, but these alert boxes aren't good as they block the whole event loop i.e nothing can run asynchronously until alert box is there 馃槃

Try to replace it with snackbars which comes out from bottom or sides and disappears after few seconds.
see this for reference https://material.io/develop/web/components/snackbars/

remove following alert boxes during verification request of pr by student

one for unauthenticated users
one for blank pr_link
one pr submitted
already created pr etc

remove two alert boxes - 30 points 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment