Added loading gif for better visualisation #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbads
approved these changes
Oct 23, 2018
| @@ -185,8 +185,14 @@ <h4> | |||
| var infiniteScroll = new Waypoint.Infinite({ | |||
| element: $('.issues-container')[0], | |||
| items: '.issue-list-item', | |||
| loadingClass: 'more-issues-loading', | |||
| more: '.more-issues-link' | |||
| //loadingClass: 'more-issues-loading', | |||
| @@ -103,10 +103,10 @@ <h4> | |||
| {% endif %} | |||
| </div> | |||
|
|
|||
| <!-- <div class="more-issues-loading container"> | |||
| <img src="static/Projects/img/loading.gif" alt="loading more issues" width="100%"> | |||
| <div class="more-issues-loading container"> | |||
There was a problem hiding this comment.
Make sure.. this gif fit to the place and doesn't look awkward 😄
|
You need to create a request for verification for achieving points for this PR 😄 |
|
but sir on contrihub-18 website there is no card made for this issue. I cannot find any to request to merge my pull request and get points. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solved issue #78