From aef1c47206949bee61d0547bc6850ccc46f413e9 Mon Sep 17 00:00:00 2001 From: Shivang Vijay Date: Sun, 6 Aug 2023 00:41:24 +0530 Subject: [PATCH 1/2] Added more comments in code and remove unwanted comments from the code --- .vscode/settings.json | 6 ++++++ concore.hpp | 16 ++++++++++------ 2 files changed, 16 insertions(+), 6 deletions(-) create mode 100644 .vscode/settings.json diff --git a/.vscode/settings.json b/.vscode/settings.json new file mode 100644 index 0000000..4db3e9a --- /dev/null +++ b/.vscode/settings.json @@ -0,0 +1,6 @@ +{ + "files.associations": { + "chrono": "cpp", + "thread": "cpp" + } +} \ No newline at end of file diff --git a/concore.hpp b/concore.hpp index 02bb36a..b74ddd7 100644 --- a/concore.hpp +++ b/concore.hpp @@ -38,8 +38,8 @@ class Concore{ char* sharedData_create; char* sharedData_get; // File sharing:- 0, Shared Memory:- 1 - int communication_iport = 0; - int communication_oport = 0; + int communication_iport = 0; // iport refers to input port + int communication_oport = 0; // oport refers to input port public: double delay = 1; @@ -58,17 +58,22 @@ class Concore{ oport = mapParser("concore.oport"); std::map::iterator it_iport = iport.begin(); std::map::iterator it_oport = oport.begin(); - int iport_number = ExtractNumeric(it_iport->first); + int iport_number = ExtractNumeric(it_iport->first); int oport_number = ExtractNumeric(it_oport->first); + // if iport_number and oport_number is equal to -1 then it refers to File Method, + // otherwise it refers to Shared Memory and the number represent the unique key. + if(oport_number != -1) { + // oport_number is not equal to -1 so refers to SM and value is key. communication_oport = 1; this->createSharedMemory(oport_number); } if(iport_number != -1) { + // iport_number is not equal to -1 so refers to SM and value is key. communication_iport = 1; this->getSharedMemory(iport_number); } @@ -112,6 +117,7 @@ class Concore{ if (numDigits == 1) { + // this case is to avoid shared memory when there is just 0 or any negative value in front of edge. if (std::stoi(numberString) <= 0) { return -1; @@ -348,7 +354,6 @@ class Concore{ if (sharedData_get && sharedData_get[0] != '\0') { std::string message(sharedData_get, strnlen(sharedData_get, 256)); ins = message; - // std::cout << "Received message: " << message << " ins " << ins.length() << std::endl; } else { @@ -367,7 +372,6 @@ class Concore{ this_thread::sleep_for(timespan); try{ if(shmId_get != -1) { - std::cout << "in read while\n"; std::string message(sharedData_get, strnlen(sharedData_get, 256)); ins = message; retrycount++; @@ -379,7 +383,7 @@ class Concore{ } //observed retry count in C++ from various tests is approx 80. catch(...){ - cout<<"Read error"; + std::cout << "Read error" << std::endl; } } s += ins; From 284f66aa2f332f48152c77dfb41121595a042742 Mon Sep 17 00:00:00 2001 From: Shivang Vijay Date: Sun, 6 Aug 2023 00:44:08 +0530 Subject: [PATCH 2/2] Remove .vscode config file --- .vscode/settings.json | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 .vscode/settings.json diff --git a/.vscode/settings.json b/.vscode/settings.json deleted file mode 100644 index 4db3e9a..0000000 --- a/.vscode/settings.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "files.associations": { - "chrono": "cpp", - "thread": "cpp" - } -} \ No newline at end of file