-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.2.1 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n7studios
requested review from
corydhmiller,
brendancarney,
jenessawhite and
noelherrick
February 3, 2022 17:58
brendancarney
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since many of the changes were tests and reorganization, I skimmed most of this, and nothing jumped out at me. I think it's good to go.
jenessawhite
approved these changes
Mar 15, 2022
This was referenced Mar 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Version 1.2.1 of the ConvertKit Gravity Forms Plugin introduces the below additions and fixes.
The Plugin can be viewed at https://cktestplugins.wpengine.com/wp-admin/; @corydhmiller can provide access to anyone reviewing who doesn't yet have this.
Specifically, this addresses:
On WordPress' Support Forums, this addresses:
Testing
Our testing framework, used for the main ConvertKit Plugin and the ConvertKit for WooCommerce Plugin, is applied to this version. Specifically, the following tests have been created:
Checklist