Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.1 #36

Merged
merged 21 commits into from
Mar 17, 2022
Merged

1.2.1 #36

merged 21 commits into from
Mar 17, 2022

Conversation

n7studios
Copy link
Contributor

Summary

Version 1.2.1 of the ConvertKit Gravity Forms Plugin introduces the below additions and fixes.

The Plugin can be viewed at https://cktestplugins.wpengine.com/wp-admin/; @corydhmiller can provide access to anyone reviewing who doesn't yet have this.

  • Added: PHP 8.x compatibility
  • Added: Developers: Action and filter hooks. See https://github.com/ConvertKit/convertkit-woocommerce/blob/1.4.2/ACTIONS-FILTERS.md
  • Added: Developers: Capabilities for Settings Page, Form Settings and Uninstall actions
  • Added: Settings: Debug option
  • Added: Form: Feed Settings: Optionally tag subscriber
  • Added: Form: Feed Settings: Optionally map a Form Field to be used as the value for tagging a subscriber
  • Added: Form: Entries: Log success and error messages to Form Entries' Notes
  • Fix: Settings: API Key: Show error notification and contextual tooltip error message when an invalid API Key is specified
  • Fix: Form: Feed Settings: Don't attempt to subscribe to ConvertKit if the Email field's value isn't an email address

Specifically, this addresses:

On WordPress' Support Forums, this addresses:

Testing

Our testing framework, used for the main ConvertKit Plugin and the ConvertKit for WooCommerce Plugin, is applied to this version. Specifically, the following tests have been created:

  • ActivateDeactivatePluginCest: Tests Plugin activation and deactivation, with and without Gravity Forms activated
  • AnyErrorsOnBlankInstallCest: Tests that no errors are output on a new installation
  • FormCest: Tests various Gravity Form and Form Feed configuration combinations send / do not send data to ConvertKit through the API as expected
  • SettingCest: Tests that setting the API Key (or not) and enabling / disabling debugging works as expected

Checklist

Copy link

@brendancarney brendancarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since many of the changes were tests and reorganization, I skimmed most of this, and nothing jumped out at me. I think it's good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants