Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some site cookies show 0 (zero) in "Manage Data" after getting "deleted" #512

Open
planket2 opened this issue Mar 23, 2019 · 12 comments

Comments

Projects
None yet
7 participants
@planket2
Copy link

commented Mar 23, 2019

Describe the Bug/Feature

Some site cookies don't get removed completely after closing tabs, for example
rottentomatoes.com
twitter.com

I dont have any other old tabs open from those sites, i open them first time and then after closing them.. an empty cookie or 0 is still shown under "Manage Data"
However the popup does state that it deleted the cookies from rottentomatoes.com
but still shows as 0 under "Manage Data"

Please see screenshot attached
2019-03-23_10-07

Steps for anyone to reproduce the bug

Your settings

  • OS/version: Ubuntu 18.04
  • Browser/version: Firefox 66.0
  • Cookie AutoDelete version: 3.0.1
@kennethtran93

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2019

what is your settings like (i.e. a screenshot of the webextension settings page)? I feel like the clear localstorage option isn't checked. The storage shown above in your screenshot isn't just cookies, but site data and/or localstorage as well.

@xopez

This comment has been minimized.

Copy link

commented Mar 27, 2019

Having the same. Local Storage is checked.
grafik
FF 66.0.1
Windows 1803
CAD version: 3.0.1

@pezz

This comment has been minimized.

Copy link

commented Mar 28, 2019

I actually think the "Manage Cookies and Site Data" thing is a bit broken, even in the latest version of Firefox (66.0.2). I sometimes have to manually remove and restart FF multiple times to get rid of some sites' data.

However, even with temporary containers, CAD etc, everytimezone.com always seems to leave a cookie / localstorage entry after a few visits and it never gets cleaned. So I have certainly seen the behavior planket2 describes.

@planket2

This comment has been minimized.

Copy link
Author

commented Mar 28, 2019

@kennethtran93 on the contrary - the clear localstorage option is checked.
This must be a bug as others are experiencing the same thing.
I even tried on a fresh Firefox installation.

@pezz yes i often have to do the same thing and restart Firefox to get rid of leftovers completely.

@kennethtran93

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

@pezz @planket2 I'm not sure how firefox displays the storage size completely, but based on my interpretation from the following screenshot, it's a firefox thing (or a bug on their end) and not a bug with this webextension itself.

Options - Mozilla Firefox

As per the words in the top part of the screenshot, there's cookies, persistent storage, and data from non-persistent storage. Second sentence explicitly states that persistent storage will be deleted when we want to, but the website data in the non-persistent storage will (only) be deleted when firefox deems that it needs the space.

The storage size may be calculated from both persistent and non-persistent combined, thus clearing the localstorage and cookies may only delete the persistent portion of the storage for that website, hence why we see zero cookies and that some storage may still exist - they may be from non-persistent storage, and from my brief research into the storage API on firefox it only has delete all for localStorage.

@pezz

This comment has been minimized.

Copy link

commented Apr 2, 2019

but the website data in the non-persistent storage will (only) be deleted when firefox deems that it needs the space

Hmm, yeah doesn't sound very "non-persistent" to me, heh.

I use temporary containers and CAD, yet I have data from youtube.com (448k of it) according to the Manage window. Neither the temp container going away or CAD removed it. Something seems broken, just not sure what.

@mrdokenny

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

Firefox lumps IndexedDB and localstorage in that storage size count. CAD can remove localstorage per site but not IndexedDB per site.

#171

@helgasoft

This comment has been minimized.

Copy link

commented Apr 30, 2019

Firefox languishes, but Chrome does have code to delete IndexedDB databases per (current) site.

@planket2

This comment has been minimized.

Copy link
Author

commented May 10, 2019

@mrdokenny im not sure if this is related - but i have a feeling it is.
When going to epayments.com and then closing the tab. the cookie removes it but not the storage IndexedDB as you said. However, when closing firefox and re-opening, it still does NOT remove epayments.com cookies. it persists across restarts of firefox.

The ONLY thing that worked, was literally going to manage data - selecting the cookie and clicking "Remove Selected" and then clicking "Save Changes" after which it asks to confirm to delete the specified cookie.
This is the only way it will delete it after it persisting. What are we going to do about sites like these?

Although i understand you said it cannot delete IndexedDB per site, Can't you program cookieAutoDelete to be able to use the exact same function as when clicking under Manage Data > Delete Specified Cookie > & Save Changes ?

@jj123

This comment has been minimized.

Copy link

commented May 15, 2019

There's a thread about this on FF's forum:

jscher2000 - "Twitter was a good example. Mine also shows 64 KB stored. And when I look in the storage folder on disk, I see a 64 KB caches.sqlite file (first screenshot). When I use a SQLite viewer web app to look inside, however, all of its tables are empty -- zero rows (second screenshot)."

https://support.mozilla.org/en-US/questions/1258708

@jj123

This comment has been minimized.

Copy link

commented May 22, 2019

So is this an issue for FF to fix or can Cookie-AutoDelete cure the issue (even if it is FF's issue)?

@kennethtran93

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

I think it's a FF limitation at this time, since I don't believe they exposed an API for that yet...I could be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.