Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapping the "OK" button too fast while UIPickerView is still "animating/rotating" results in the wrong/previous selection. Should delay action/unload? #50

Open
benguild opened this issue Oct 5, 2016 · 2 comments

Comments

@benguild
Copy link

benguild commented Oct 5, 2016

I've run into this while working a bit too quickly between views before.

If you flick the UIPickerView to a selection, and then it nearly finishes rotating but hasn't 100% finished when you hit "OK", the previous value will still be considered active because the new delegate method hasn't fired before the other callbacks and stuff go through for "OK".

This is a problem with UIPickerView (not this module) in general to be honest... but requires a workaround. It's clear that a selection has been made by the user because it's already settled on a given choice and isn't accelerating fast enough to move past it, but it doesn't account for the fact that there's no reason the user would want the previous selection at that point instead without pressing "Cancel".

Is it possible to get a fix or workaround for this?

@CooperRS
Copy link
Owner

CooperRS commented Oct 5, 2016

Hey, I'm aware of that problem. Unfortunately, I do not know of an solution, as UIPickerView as well as UIDatePicker does not tell anyone when the selection has finished (at least as far as I know). Can you help out?

Related: CooperRS/RMDateSelectionViewController#25

@benguild
Copy link
Author

benguild commented Oct 5, 2016

OK, I will respond on that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants