Address review feedback for Claude uvx

Author: dsarno

MCPForUnity/Editor/Clients/Configurators/ClaudeDesktopConfigurator.cs

@@ -9,9 +9,11 @@ namespace MCPForUnity.Editor.Clients.Configurators
 {
     public class ClaudeDesktopConfigurator : JsonFileMcpConfigurator
     {
+        public const string ClientName = "Claude Desktop";
+
         public ClaudeDesktopConfigurator() : base(new McpClient
         {
-            name = "Claude Desktop",
+            name = ClientName,
             windowsConfigPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), "Claude", "claude_desktop_config.json"),
             macConfigPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), "Library", "Application Support", "Claude", "claude_desktop_config.json"),
             linuxConfigPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".config", "Claude", "claude_desktop_config.json"),

MCPForUnity/Editor/Helpers/ConfigJsonBuilder.cs

@@ -3,6 +3,7 @@
 using System.IO;
 using System.Linq;
 using MCPForUnity.Editor.Constants;
+using MCPForUnity.Editor.Clients.Configurators;
 using MCPForUnity.Editor.Helpers;
 using MCPForUnity.Editor.Models;
 using Newtonsoft.Json;
@@ -176,7 +177,7 @@ private static bool ShouldUseWindowsCmdShim(McpClient client)
             }
 
             return Application.platform == RuntimePlatform.WindowsEditor &&
-                   string.Equals(client.name, "Claude Desktop", StringComparison.OrdinalIgnoreCase);
+                   string.Equals(client.name, ClaudeDesktopConfigurator.ClientName, StringComparison.OrdinalIgnoreCase);
         }
 
         private static string ResolveCmdPath()

MCPForUnity/Editor/Windows/Components/ClientConfig/McpClientConfigSection.cs

@@ -346,8 +346,13 @@ private void RefreshClaudeCliStatus(IMcpClientConfigurator client, bool forceImm
                 Task.Run(() =>
                 {
                     MCPServiceLocator.Client.CheckClientStatus(client, attemptAutoRewrite: false);
-                }).ContinueWith(_ =>
+                }).ContinueWith(t =>
                 {
+                    if (t.IsFaulted && t.Exception != null)
+                    {
+                        McpLog.Error($"Failed to refresh Claude CLI status: {t.Exception.GetBaseException().Message}");
+                    }
+
                     EditorApplication.delayCall += () =>
                     {
                         statusRefreshInFlight.Remove(client);

TestProjects/UnityMCPTests/Assets/Tests/EditMode/Helpers/WriteToConfigTests.cs

@@ -8,6 +8,7 @@
 using MCPForUnity.Editor.Helpers;
 using MCPForUnity.Editor.Models;
 using MCPForUnity.Editor.Constants;
+using MCPForUnity.Editor.Services;
 
 namespace MCPForUnityTests.Editor.Helpers
 {
@@ -175,7 +176,7 @@ public void ClaudeDesktop_UsesAbsoluteUvPath_WhenOverrideProvided()
 
             WithTransportPreference(false, () =>
             {
-                EditorPrefs.SetString(EditorPrefKeys.UvxPathOverride, "/abs/mock/uvx");
+                MCPServiceLocator.Paths.SetUvxPathOverride(_fakeUvPath);
                 try
                 {
                     var client = new McpClient
@@ -190,13 +191,13 @@ public void ClaudeDesktop_UsesAbsoluteUvPath_WhenOverrideProvided()
                     var root = JObject.Parse(File.ReadAllText(configPath));
                     var unity = (JObject)root.SelectToken("mcpServers.unityMCP");
                     Assert.NotNull(unity, "Expected mcpServers.unityMCP node");
-                    Assert.AreEqual("/abs/mock/uvx", (string)unity["command"], "Claude Desktop should use absolute uvx path");
+                    Assert.AreEqual(_fakeUvPath, (string)unity["command"], "Claude Desktop should use absolute uvx path");
                     Assert.IsNull(unity["env"], "Claude Desktop config should not include env block when not required");
                     AssertTransportConfiguration(unity, client);
                 }
                 finally
                 {
-                    EditorPrefs.DeleteKey(EditorPrefKeys.UvxPathOverride);
+                    MCPServiceLocator.Paths.ClearUvxPathOverride();
                 }
             });
         }