Skip to content

Conversation

@bilal-arikan
Copy link
Contributor

@bilal-arikan bilal-arikan commented Oct 22, 2025

Hi,
I’ve added TRAE IDE support. The project should now be easier to work with and better supported in TRAE IDE.

let me know if this is ok or need some changes.

#65

Summary by CodeRabbit

Release Notes

  • New Features
    • Added Trae IDE as a new MCP client option with cross-platform configuration support for Windows, macOS, and Linux environments
    • Integrated setup instructions and manual configuration guidance for Trae in the editor interface
    • Extended MCP client detection and initialization to recognize Trae installations

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

Walkthrough

Adds support for Trae IDE as a new MCP client type across MCPForUnity and UnityMcpBridge packages. Introduces Trae enum member, configuration paths for Windows/macOS/Linux, installation instructions in the UI, and a verification test.

Changes

Cohort / File(s) Summary
Trae Enum Type
MCPForUnity/Editor/Models/McpTypes.cs, UnityMcpBridge/Editor/Models/McpTypes.cs
Adds Trae as a new enum member to McpTypes
Trae Client Registry
MCPForUnity/Editor/Data/McpClients.cs, UnityMcpBridge/Editor/Data/McpClients.cs
Registers Trae with platform-specific config paths (Windows: %AppData%\Trae\mcp.json, macOS: ~/Library/Application Support/Trae/mcp.json, Linux: ~/.config/Trae/mcp.json) and "Not Configured" status
Trae UI Instructions
MCPForUnity/Editor/Windows/ManualConfigEditorWindow.cs, UnityMcpBridge/Editor/Windows/ManualConfigEditorWindow.cs
Adds conditional UI branch to display Trae-specific setup instructions: "a) Going to Settings > MCP > Add Server > Add Manually"
Trae Installation Steps
MCPForUnity/Editor/Services/ClientConfigurationService.cs
Adds GetInstallationSteps case for Trae to provide setup guidance
Trae Config Test
TestProjects/UnityMCPTests/Assets/Tests/EditMode/Helpers/WriteToConfigTests.cs
Adds DoesNotAddEnvOrDisabled_ForTrae test to verify Trae clients exclude env and disabled entries in unityMCP config

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The changes follow a consistent, repetitive pattern across two packages: adding an enum value and corresponding conditional branches with platform-specific configuration paths. No complex logic or error handling; straightforward additions aligned with existing client type patterns.

Possibly related PRs

Poem

🐰 A new IDE joins the fray—Trae,
With paths for every system's way,
The enum grows, the config gleams,
Instructions bright for developer dreams,
Tests in place to keep it right! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Update to support Trae" directly and accurately describes the primary change in this changeset. The modifications add Trae IDE as a new MCP client type across multiple files, including new enum values, client configuration entries, UI instructions, and test coverage. The title is concise, specific to Trae IDE, and avoids vague terminology or noise. A developer scanning pull request history would immediately understand that this PR introduces Trae IDE support to the project.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3e5485 and f8c3023.

📒 Files selected for processing (8)
  • MCPForUnity/Editor/Data/McpClients.cs (1 hunks)
  • MCPForUnity/Editor/Models/McpTypes.cs (1 hunks)
  • MCPForUnity/Editor/Services/ClientConfigurationService.cs (1 hunks)
  • MCPForUnity/Editor/Windows/ManualConfigEditorWindow.cs (1 hunks)
  • TestProjects/UnityMCPTests/Assets/Tests/EditMode/Helpers/WriteToConfigTests.cs (1 hunks)
  • UnityMcpBridge/Editor/Data/McpClients.cs (1 hunks)
  • UnityMcpBridge/Editor/Models/McpTypes.cs (1 hunks)
  • UnityMcpBridge/Editor/Windows/ManualConfigEditorWindow.cs (1 hunks)
🔇 Additional comments (8)
UnityMcpBridge/Editor/Models/McpTypes.cs (1)

12-12: LGTM!

Clean addition of the Trae enum member to support the new IDE type.

MCPForUnity/Editor/Data/McpClients.cs (1)

136-163: Well-structured Trae client entry.

The entry follows the established pattern for other MCP clients and uses standard OS-specific paths. The configuration paths align with those mentioned in the installation steps.

MCPForUnity/Editor/Models/McpTypes.cs (1)

12-12: LGTM!

Consistent enum addition to support Trae IDE.

TestProjects/UnityMCPTests/Assets/Tests/EditMode/Helpers/WriteToConfigTests.cs (1)

131-145: LGTM! Good test coverage for Trae configuration behavior.

The test correctly verifies that Trae follows the same pattern as Cursor (no env/disabled fields), distinguishing it from Windsurf/Kiro which require these fields. This ensures consistent configuration handling.

MCPForUnity/Editor/Windows/ManualConfigEditorWindow.cs (1)

111-117: UI addition looks consistent.

The Trae-specific instruction branch follows the established pattern for other MCP clients. Ensure the menu path "Settings > MCP > Add Server > Add Manually" matches Trae's actual UI.

UnityMcpBridge/Editor/Windows/ManualConfigEditorWindow.cs (1)

111-117: UI addition is consistent with MCPForUnity package.

The Trae instruction branch mirrors the implementation in the MCPForUnity package, maintaining consistency across both editor packages.

UnityMcpBridge/Editor/Data/McpClients.cs (1)

137-161: LGTM! Consistent with MCPForUnity package.

The Trae client entry is correctly duplicated in the UnityMcpBridge package with identical configuration, maintaining consistency across both editor implementations.

MCPForUnity/Editor/Services/ClientConfigurationService.cs (1)

462-470: Verify Trae IDE installation steps and paths

  • Confirm the menu path “Settings > MCP > Add Server > Add Manually” matches Trae’s current UI.
  • Update the config-file paths:
    • Windows: %APPDATA%\Trae\User\mcp.json
    • macOS: ~/.config/Trae/User/mcp.json
    • Linux: ~/.config/Trae/User/mcp.json
    • (Optional) Project-level: .trae/mcp.json inside a workspace.
  • Clarify step 4’s requirements: does Trae need Node.js (npx) separately, or is uvx (from uv) sufficient?

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@msanatan msanatan self-requested a review October 22, 2025 21:37
Copy link
Contributor

@msanatan msanatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you

@msanatan
Copy link
Contributor

This closes #65

@msanatan msanatan merged commit d4214ce into CoplayDev:main Oct 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants