hey #6

merged 1 commit into from Sep 6, 2011


None yet
2 participants

robinboening commented Oct 24, 2010

i made a little change on the Geomap class.
I got an error, thrown by googles javascript, wich told me i must not use an index of 73.
i figured out that my 73 record is the first one wich is geocoded.

In the loop for building the data_table you check for geocoded records and step to the next record if false...
so the index of the loop is getting higher and higher without building the table.

So my first record in the data_table got an column index of 73...

My Solution:
Before looping through all the records, i select only te geocoded records an loop through them.
So theres no need for further checking.


filtering geocoded data before going into each-loop. now your columns…
… are not counted if record is not geocoded. Otherwise it will throw an error if you start with an index wich is not zero.

CoralineAda pushed a commit that referenced this pull request Sep 6, 2011

Corey Ehmke
Merge pull request #6 from robinboening/master
Fixes JS error in Geomap

@CoralineAda CoralineAda merged commit 76084cd into CoralineAda:master Sep 6, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment