New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max_id and since_id parameter documentation #76

Merged
1 commit merged into from Jul 20, 2014

Conversation

Projects
None yet
2 participants
@a4lg
Contributor

a4lg commented Jul 20, 2014

Their type should be long, not int.
Please note that there's no implementation issue because CoreTweet accepts max_id and since_id as long numbers.

……と説明にあるように、ドキュメントにおける max_id と since_id が本来あるべき long 型ではなく int 型と記されていたことに関する修正で、実装に関する修正はありません (CoreTweet がパラメータの型を柔軟に受け付けるため; テストで実装上は問題が無いことは確認)。

Fix max_id and since_id parameter documentation
Their type should be `long', not `int'.
Please note that there's no implementation issue because
CoreTweet accepts max_id and since_id as long numbers.

ghost pushed a commit that referenced this pull request Jul 20, 2014

Merge pull request #76 from a4lg/fix/doc-id-range
Fix max_id and since_id parameter documentation

@ghost ghost merged commit 7060570 into CoreTweet:master Jul 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@a4lg a4lg deleted the a4lg:fix/doc-id-range branch Jul 20, 2014

@azyobuzin

This comment has been minimized.

Show comment
Hide comment
@azyobuzin

azyobuzin Jul 20, 2014

Member

user_id も int になってるのを確認

Member

azyobuzin commented Jul 20, 2014

user_id も int になってるのを確認

@a4lg

This comment has been minimized.

Show comment
Hide comment
@a4lg

a4lg Jul 20, 2014

Contributor

@azyobuzin user_id に関しても同様の Pull Request を投げました。これらの型は後でじっくり確認するべきかもしれませんね。

Contributor

a4lg commented Jul 20, 2014

@azyobuzin user_id に関しても同様の Pull Request を投げました。これらの型は後でじっくり確認するべきかもしれませんね。

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment