Skip to content

add the possibility to disable all quotes in a csv file #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amanteaux merged 3 commits into from
Sep 12, 2018
Merged

add the possibility to disable all quotes in a csv file #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a199787
add the possibility to disable all quotes in a csv file
Aug 23, 2018
8c84159
rename disabledQuotes to applyQuotesToAll
Sep 12, 2018
d12a355
change !isApplyQuotesToAll
Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/coreoz/windmill/exports/exporters/csv/CsvExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ private void writeHeaderRow() {
for (int i = 0; i < headerColumn.size(); i++) {
csvRowValues[i] = stringValue(headerColumn.get(i));
}
csvWriter.writeNext(csvRowValues);
csvWriter.writeNext(csvRowValues,exportConfig.isApplyQuotesToAll());
}
}

Expand All @@ -81,7 +81,7 @@ private void writeRow(T row) {
for (int i = 0; i < mapping.columnsCount(); i++) {
csvRowValues[i] = stringValue(mapping.cellValue(i, row));
}
csvWriter.writeNext(csvRowValues);
csvWriter.writeNext(csvRowValues, exportConfig.isApplyQuotesToAll());
csvWriter.flush();
}

Expand Down
3 changes: 3 additions & 0 deletions src/main/java/com/coreoz/windmill/exports/exporters/csv/ExportCsvConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,8 @@ public class ExportCsvConfig {
@Builder.Default private final char escapeChar = ICSVParser.DEFAULT_ESCAPE_CHARACTER;
/** The line feed terminator to use */
@Builder.Default private final String lineEnd = CSVWriter.DEFAULT_LINE_END;
/** The boolean to use for applying or not optional wrapping quotes */
@Builder.Default private final boolean applyQuotesToAll = true;


}