Print error in case XRPL tx scanning is failed and retry after timeout.

[dzmitryhil]

Description

Print error in case XRPL tx scanning is failed and retry after timeout.

Reviewers checklist:

• Try to write more meaningful comments with clear actions to be taken.
• Nit-picking should be unblocking. Focus on core issues.

Authors checklist

• Provide a concise and meaningful description
• Review the code yourself first, before making the PR.
• Annotate your PR in places that require explanation.
• Think and try to split the PR to smaller PR if it is big.

---

This change is 

[ysv]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @wojtek-coreum)

---

relayer/xrpl/scanner.go line 139 at r1 (raw file):

		// set minLedger to start with it in next iteration
		// even if the error was returned we still re-scan from the lastLedger
		if lastLedger != 0 {

I can see that you assign minLedger to -1 in some places
Is it ok that you compare it to 0 here ? maybe it should be if lastLedger > 0 ?

For me it is not clear what is the logic behind -1 here

[dzmitryhil]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, @wojtek-coreum, and @ysv)

---

relayer/xrpl/scanner.go line 139 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

I can see that you assign minLedger to -1 in some places
Is it ok that you compare it to 0 here ? maybe it should be if lastLedger > 0 ?

For me it is not clear what is the logic behind -1 here

Actually both are OK, but agree if lastLedger > 0 is better. Updated.

[miladz68]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @wojtek-coreum, and @ysv)

[ysv]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @wojtek-coreum)

[miladz68]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh, @wojtek-coreum, and @ysv)

[ysv]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @wojtek-coreum)