New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warnings in examples / add documentation (CPAN Pull Request Challenge) #30

Merged
merged 2 commits into from Nov 23, 2018

Conversation

Projects
None yet
2 participants
@HaraldJoerg
Copy link
Contributor

HaraldJoerg commented Nov 22, 2018

Here are some suggested changes, mostly for the examples:

  • Avoid warning of uninitialized Log4Perl by adding including 'easy'
  • Added name, synopsis and description where it was missing
  • Added sendkeys to README
  • html-to-pdf.pl: Instead of the loop over ARGV, process only one file. Two reasons: 1) output went to the same file anyway, overwriting previous renderings, and 2) with the pure-perl event loop, the second request hangs infinitely - seems that there's no event happening. With EV all is fine.
  • A data file links.html was added (needed by dump-links.pl)
  • Not related to the examples: A test file was moved from the root directory to /t, with some changes I received per Mail.

I've re-generated Examples.pm but not yet made changes to the Changes file.

@Corion Corion merged commit 68867d9 into Corion:master Nov 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Corion

This comment has been minimized.

Copy link
Owner

Corion commented Nov 23, 2018

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment