New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly skip test if PMC disabled #7

Merged
merged 1 commit into from Oct 9, 2016

Conversation

Projects
None yet
3 participants
@choroba
Contributor

choroba commented Oct 8, 2016

Fix RT102626.

First, it tries Config::non_bincompat_options to find out, then
Config::Perl::V, and finally checks $Config{ccflags}.

Correctly skip test if PMC disabled
Fix RT102626.

First, it tries Config::non_bincompat_options to find out, then
Config::Perl::V, and finally checks $Config{ccflags}.
$pmc = 0
if grep { $_ eq 'PERL_DISABLE_PMC' } Config::non_bincompat_options();
} elsif (eval {
require Config::Perl::V;

This comment has been minimized.

@choroba

choroba Oct 8, 2016

Contributor

The original patch had

require 'Config/Perl/V.pm';

Why? Could Config::Perl::V come as pmc?

@choroba

choroba Oct 8, 2016

Contributor

The original patch had

require 'Config/Perl/V.pm';

Why? Could Config::Perl::V come as pmc?

@@ -14,11 +14,25 @@ use lib 't/lib';
plan skip_all => ".pmc are only available with 5.6 and later" if $] < 5.006;
my $no_pmc = defined &Config::non_bincompat_options

This comment has been minimized.

@choroba

choroba Oct 8, 2016

Contributor

defined returns false even if can returns true (the sub is predeclared in Config.pm).

@choroba

choroba Oct 8, 2016

Contributor

defined returns false even if can returns true (the sub is predeclared in Config.pm).

@choroba

This comment has been minimized.

Show comment
Hide comment
@choroba
Contributor

choroba commented Oct 8, 2016

@Corion Corion merged commit 0962ece into Corion:master Oct 9, 2016

@dolmen

This comment has been minimized.

Show comment
Hide comment
@dolmen

dolmen Oct 10, 2016

Contributor

I would have appreciated that my authorship of the patch would have been preserved in the commit as my patch was submitted a long time ago in #3.

Contributor

dolmen commented Oct 10, 2016

I would have appreciated that my authorship of the patch would have been preserved in the commit as my patch was submitted a long time ago in #3.

@choroba

This comment has been minimized.

Show comment
Hide comment
@choroba

choroba Oct 10, 2016

Contributor

@dolmen Do you mean being mentioned in Changes, or should I have cherry-picked your original commit and start from there? If the latter, I apologise.

Contributor

choroba commented Oct 10, 2016

@dolmen Do you mean being mentioned in Changes, or should I have cherry-picked your original commit and start from there? If the latter, I apologise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment