New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some installation pod and move 99-* tests to xt directory #14

Merged
merged 3 commits into from Apr 15, 2016

Conversation

Projects
None yet
3 participants
@lharey
Contributor

lharey commented Apr 15, 2016

Hi

As per our emails about the Pull Request challenge.

I have tested the ubuntu installation of phantomjs and added the details to pod.

I have moved the 99-* tests to xt directory and also added a new test xt/99-compile.t

Hope this is what you require.

Regards
Lisa

@Corion Corion merged commit 14be55c into Corion:master Apr 15, 2016

@Corion

This comment has been minimized.

Show comment
Hide comment
@Corion

Corion Apr 16, 2016

Owner

Hello Lisa,

thank you very much! This is far more than I expected and I'm really
thankful for the great work you've done integrating the parts!

Thanks for participating in the Pull Request Challenge!

-max

Am 15.04.2016 um 17:30 schrieb Lisa Hare:

Hi

As per our emails about the Pull Request challenge.

I have tested the ubuntu installation of phantomjs and added the details
to pod.

I have moved the 99-* tests to xt directory and also added a new test
xt/99-compile.t

Hope this is what you require.

Regards
Lisa


    You can view, comment on, or merge this pull request online at:

#14

    Commit Summary


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#14

Owner

Corion commented Apr 16, 2016

Hello Lisa,

thank you very much! This is far more than I expected and I'm really
thankful for the great work you've done integrating the parts!

Thanks for participating in the Pull Request Challenge!

-max

Am 15.04.2016 um 17:30 schrieb Lisa Hare:

Hi

As per our emails about the Pull Request challenge.

I have tested the ubuntu installation of phantomjs and added the details
to pod.

I have moved the 99-* tests to xt directory and also added a new test
xt/99-compile.t

Hope this is what you require.

Regards
Lisa


    You can view, comment on, or merge this pull request online at:

#14

    Commit Summary


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#14

@dk

This comment has been minimized.

Show comment
Hide comment
@dk

dk Apr 16, 2016

Contributor

Hi Max,

I'd very much like to ask you to look at #13 ang give your feedback. You're not merging it so far and that's okay, you have youre reasons, but I'd like to hear if there's anything wrong with my patches

Thank you
Dmitry

Contributor

dk commented Apr 16, 2016

Hi Max,

I'd very much like to ask you to look at #13 ang give your feedback. You're not merging it so far and that's okay, you have youre reasons, but I'd like to hear if there's anything wrong with my patches

Thank you
Dmitry

@Corion

This comment has been minimized.

Show comment
Hide comment
@Corion

Corion Apr 16, 2016

Owner

Hi Dimitry,

those are next on my list :)

I'm not too fond of adding the ->find_css and ->find_xpath (because
there already is ->selector, I think), but the others will likely be
merged soonish as well. The CPAN Pull Request Challenge was what
prompted me to revisit the patches.

Thanks for the patches
-max

Am 16.04.2016 um 10:10 schrieb Dmitry Karasik:

Hi Max,

I'd very much like to ask you to look at #13
#13 ang give
your feedback. You're not merging it so far and that's okay, you have
youre reasons, but I'd like to hear if there's anything wrong with my
patches

Thank you
Dmitry


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#14 (comment)

Owner

Corion commented Apr 16, 2016

Hi Dimitry,

those are next on my list :)

I'm not too fond of adding the ->find_css and ->find_xpath (because
there already is ->selector, I think), but the others will likely be
merged soonish as well. The CPAN Pull Request Challenge was what
prompted me to revisit the patches.

Thanks for the patches
-max

Am 16.04.2016 um 10:10 schrieb Dmitry Karasik:

Hi Max,

I'd very much like to ask you to look at #13
#13 ang give
your feedback. You're not merging it so far and that's okay, you have
youre reasons, but I'd like to hear if there's anything wrong with my
patches

Thank you
Dmitry


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#14 (comment)

@dk

This comment has been minimized.

Show comment
Hide comment
@dk

dk Apr 16, 2016

Contributor

That's all right! Good to know :)

Contributor

dk commented Apr 16, 2016

That's all right! Good to know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment