New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1321: Adds default build path to .gitignore #1322

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
2 participants
@pschoffer
Contributor

pschoffer commented Jan 8, 2018

Even though the recommended path to build the game is outside the source, when running make without specifying path the game still gets build to CorsixTH/CorsixTH. That's why I created this PR anyway:) Please see the issue for more info.

@TheCycoONE

This comment has been minimized.

Show comment
Hide comment
@TheCycoONE

TheCycoONE Jan 8, 2018

Member

Since it's a path, please include the trailing /

Member

TheCycoONE commented Jan 8, 2018

Since it's a path, please include the trailing /

@pschoffer

This comment has been minimized.

Show comment
Hide comment
@pschoffer

pschoffer Jan 8, 2018

Contributor

Ohhh. I was wrong. So I thought the whole CorsixTH (insede the CorsixTH repo is build), but is only a CorsixTH/CorsixTH executable file. Meaning only the file should be ignored in my opinion. Meaning I can't put the trailing / as git will then look for folder and not match files. Do you think we could keep it as is then?

Contributor

pschoffer commented Jan 8, 2018

Ohhh. I was wrong. So I thought the whole CorsixTH (insede the CorsixTH repo is build), but is only a CorsixTH/CorsixTH executable file. Meaning only the file should be ignored in my opinion. Meaning I can't put the trailing / as git will then look for folder and not match files. Do you think we could keep it as is then?

@TheCycoONE TheCycoONE merged commit 1ce778c into CorsixTH:master Jan 8, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment