New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Interrupted walk should refer to original must_happen #1453

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
2 participants
@mugmuggy
Contributor

mugmuggy commented Sep 1, 2018

Addresses #1439. Where a walk action is interrupted to a drinks machine resulting in an incorrect 'must_happen' walk after the drinks machine use.

@mugmuggy mugmuggy changed the title from [RFC] Interrupted walk should refer to original must_happen to [RDY] Interrupted walk should refer to original must_happen Sep 11, 2018

@mugmuggy mugmuggy changed the title from [RDY] Interrupted walk should refer to original must_happen to [RFC] Interrupted walk should refer to original must_happen Sep 13, 2018

@mugmuggy

This comment has been minimized.

Show comment
Hide comment
@mugmuggy

mugmuggy Sep 13, 2018

Contributor

I've noticed the same logical bug in Patient:falling, vomit and pee methods, I'll push another commit to cover them also.

Contributor

mugmuggy commented Sep 13, 2018

I've noticed the same logical bug in Patient:falling, vomit and pee methods, I'll push another commit to cover them also.

@mugmuggy mugmuggy changed the title from [RFC] Interrupted walk should refer to original must_happen to [RDY] Interrupted walk should refer to original must_happen Sep 13, 2018

@TheCycoONE TheCycoONE merged commit 8f31878 into CorsixTH:master Sep 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TheCycoONE

This comment has been minimized.

Show comment
Hide comment
@TheCycoONE

TheCycoONE Sep 14, 2018

Member

I think this needs cleaned up later

Member

TheCycoONE commented Sep 14, 2018

I think this needs cleaned up later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment