New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Show errors when loading bitmaps #1470

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@TheCycoONE
Copy link
Member

TheCycoONE commented Sep 19, 2018

Use exceptions and lua_error to show the cause of any error loading bitmaps
instead of simply false. This makes diagnosing errors much easier.

This patch was used to diagnose #1468 but does not fix the issue.

@TheCycoONE TheCycoONE force-pushed the TheCycoONE:show_errors branch from f16c888 to dcc41dd Sep 19, 2018

@TheCycoONE TheCycoONE changed the title [RDY] Show errors when loading bitmaps [WIP] Show errors when loading bitmaps Sep 19, 2018

@TheCycoONE

This comment has been minimized.

Copy link
Member

TheCycoONE commented Sep 19, 2018

Missed an include that MSVC didn't care about.

Show errors when loading bitmaps
Use exceptions and lua_error to show the cause of any error loading bitmaps
instead of simply false. This makes diagnosing errors much easier.

@TheCycoONE TheCycoONE force-pushed the TheCycoONE:show_errors branch from dcc41dd to 8cae111 Sep 19, 2018

@TheCycoONE TheCycoONE changed the title [WIP] Show errors when loading bitmaps [RDY] Show errors when loading bitmaps Sep 19, 2018

@Alberth289346 Alberth289346 merged commit ce473fd into CorsixTH:master Sep 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Alberth289346

This comment has been minimized.

Copy link
Contributor

Alberth289346 commented Sep 19, 2018

Nice! Sorry for not getting online, but terribly busy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment