New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Handle when no supported video stream is found #1473

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
2 participants
@TheCycoONE
Member

TheCycoONE commented Sep 20, 2018

Fixes a segfault in environments where smacker support is disabled in ffmpg.

Bug #1315

@TheCycoONE

This comment has been minimized.

Show comment
Hide comment
@TheCycoONE

TheCycoONE Sep 20, 2018

Member

RFC because this is untested.

Member

TheCycoONE commented Sep 20, 2018

RFC because this is untested.

Handle when no supported video stream is found
Fixes a segfault in environments where smacker support is disabled in ffmpg.
@TheCycoONE

This comment has been minimized.

Show comment
Hide comment
@TheCycoONE

TheCycoONE Sep 24, 2018

Member

Switched to the same error handling we use elsewhere in this routine. A future refactor could switch to exceptions.

Member

TheCycoONE commented Sep 24, 2018

Switched to the same error handling we use elsewhere in this routine. A future refactor could switch to exceptions.

@TheCycoONE TheCycoONE changed the title from [RFC] Handle when no supported video stream is found to [RDY] Handle when no supported video stream is found Sep 27, 2018

@TheCycoONE

This comment has been minimized.

Show comment
Hide comment
@TheCycoONE

TheCycoONE Sep 27, 2018

Member

Marking RDY. I don't hold out much hope in attracting people from the issue.

Member

TheCycoONE commented Sep 27, 2018

Marking RDY. I don't hold out much hope in attracting people from the issue.

@Alberth289346 Alberth289346 merged commit 02896f9 into CorsixTH:master Sep 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment