New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Litter placed before a door was placed was only found on thob checks #1474

Merged
merged 1 commit into from Sep 23, 2018

Conversation

Projects
None yet
2 participants
@mugmuggy
Copy link
Contributor

mugmuggy commented Sep 23, 2018

Using getObject with a table input to find either door type instead. Refers to #1425 still

@TheCycoONE TheCycoONE merged commit 338ea32 into CorsixTH:master Sep 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TheCycoONE

This comment has been minimized.

Copy link
Member

TheCycoONE commented Sep 24, 2018

@mugmuggy I think

if tile_flags.thob ~= 0 and tile_flags.thob ~= 62 then return false end
is the same issue - if litter and something else was on the same tile, the thob could be 62 and allow a door where it shouldn't?

@mugmuggy

This comment has been minimized.

Copy link
Contributor

mugmuggy commented Sep 24, 2018

Thats if any object but not if its litter prevent the door being placed. Litter is removed from all tiles inside a room, so its only outside where this becomes an issue. The other thing is that as it is an 'or' it only breaks on particular room orientations as it may check inside the room first, find the door and skip the rest of the statements.

Nothing stopping you building a room with a door where the adjacent tile in corridor has litter. Unfortunately when I was testing the other future pr, I had vomit everywhere that then resulted an in infinite loop of recalculating routes, and upon checking the thob found the it was 62 instead of 3.

The old walk code would redirect only where there was a wall found, so it could have also been entirely possible at one stage to build a room on the path with a door and therefore just walked over litter as it was never rerouting unless it hit that wall.

@TheCycoONE

This comment has been minimized.

Copy link
Member

TheCycoONE commented Sep 24, 2018

I meant that the litter could be masking another object that should prevent the door being placed, but since it only does the thob check the litter shows up and not the bench?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment