Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[RDY] Research fax options updating #1484
When looking at the autospy discovery issue I raised, I also noted inconsistencies with seek treatment room fax as mentioned in #453. Some of these are documented, some are differences from the original (not necessarily desired though), and there are probably more better ways to perform the same functions.
Patients seeking a treatment room fax doesn't 'exist' for the 'need_to_employ' message when room exists but not the required staff - #469
Just created for some more discussion
I can recall testing each of the individual fax changes, by removing/adding rooms and hiring/firing staff. There are a few minor things, like a commented out assert that should probably just be removed, and the other concern I had at the time was around translated strings which I didn't switch languages on to check either.
And I included the unregister callback warnings, which makes for ugly game logs when executed which I think is the reason I haven't marked as RFC/RDY as yet. Getting a review on the current implementation and I'll rebase, fix app version, the commented assert and run it through some tests again.
I had a play around with the original to see what it did. If you have an op theatre and no ward, and a patient is diagnosed with say Spare Ribs. The fax says, You cannot cure this disease at the moment.. Whereas, with this change it will Ward and Nurse (evn though you have a nurse), so its a little confused in the current state so I'll try and address that.
3 times, most recently
Mar 21, 2019
I updated based on some feedback and found another edge case that trainee doctors would cause the fax not to update. I now have them updating the messages when any special skill is added, however its only effective on surgeon skills because you need two.