Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Bump travis to Xenial #1528

Merged
merged 4 commits into from Apr 25, 2019

Conversation

Projects
None yet
3 participants
@TheCycoONE
Copy link
Member

commented Apr 18, 2019

Trying to fix broken Travis builds

@TheCycoONE TheCycoONE force-pushed the TheCycoONE:travis-luarocks branch 2 times, most recently from 3310536 to ad3eec6 Apr 18, 2019

@mugmuggy

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

This on upstream brunoos/luasec#136

@TheCycoONE

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

This on upstream brunoos/luasec#136

Sounds relevant, bumping to xenial.

@TheCycoONE TheCycoONE force-pushed the TheCycoONE:travis-luarocks branch from 73498fe to aa07ac1 Apr 18, 2019

Add ant
Not included by default in xenial
@TheCycoONE

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

Bingo, just need ant because it's not included by default anymore.

@TheCycoONE TheCycoONE changed the title [WIP] Install lua_sec to global luarocks [WIP] IBump travis to Xenial to fix luarocks Apr 18, 2019

@TheCycoONE TheCycoONE changed the title [WIP] IBump travis to Xenial to fix luarocks [WIP] Bump travis to Xenial Apr 18, 2019

@TheCycoONE TheCycoONE changed the title [WIP] Bump travis to Xenial [RDY] Bump travis to Xenial Apr 18, 2019

@wolfy1339

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

Any particular reason to still install GCC 5?

@TheCycoONE

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

@wolfy1339 no, it's default anyway, but it doesn't hurt either right?

Remove explicit gcc version
Xenial defaults to a new enough gcc.
@TheCycoONE

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

Removed explicit gcc version per @wolfy1339 's recommendation.

Bump minimum cmake version
Since Travis is bumped to Xenial we are no longer testing any CMake version
older than 3.5.

@TheCycoONE TheCycoONE merged commit ba90e73 into CorsixTH:master Apr 25, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.