Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Use DATAROOTDIR for icons, metadata on *nix #1545

Merged
merged 1 commit into from May 28, 2019

Conversation

Projects
None yet
3 participants
@TheCycoONE
Copy link
Member

commented May 25, 2019

Use DATAROOTDIR instead of DATADIR for files that belong in the root
/usr/share instead of /usr/share/**/corsix-th.

This allows putting corsix-th under /usr/share/games.

Use DATAROOTDIR for icons, metadata on *nix
Use DATAROOTDIR instead of DATADIR for files that belong in the root
/usr/share instead of /usr/share/**/corsix-th.

@TheCycoONE TheCycoONE changed the title Use DATAROOTDIR for icons, metadata on *nix [RDY] Use DATAROOTDIR for icons, metadata on *nix May 26, 2019

@TheCycoONE

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

@h3xx could you confirm this works for you

@h3xx

This comment has been minimized.

Copy link

commented May 28, 2019

Yes, I was able to get it targeting the paths I described in #1544 using the following configuration:

CMAKE_INSTALL_DATAROOTDIR=/usr/share
CMAKE_INSTALL_DATADIR=/usr/share/games

@Alberth289346 Alberth289346 merged commit 744bb0f into CorsixTH:master May 28, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.