Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] AnimView compliance fixes #1552

Merged
merged 3 commits into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@TheCycoONE
Copy link
Member

commented Jun 12, 2019

Fixes a couple cases of undefined behaviour; the use of unprefixed stdint types (via a new config.h); and semicolons after macros that triggered -Wpedantic warnings.

Fix a couple easy errors in animview
Errors reported by cppcheck
* undefined behaviour shifting a signed integer.
* memory leak if rnc length check fails.

@TheCycoONE TheCycoONE changed the title [RDY] AnimView complience fixes [RDY] AnimView compliance fixes Jun 12, 2019

@TheCycoONE TheCycoONE force-pushed the TheCycoONE:animview-ub branch from 898e204 to 8780cd6 Jun 12, 2019

@TheCycoONE TheCycoONE force-pushed the TheCycoONE:animview-ub branch from 8780cd6 to 627a00c Jun 12, 2019

@Alberth289346 Alberth289346 merged commit 5bc48d3 into CorsixTH:master Jun 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.