Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Some assorted issues #1567

Merged
merged 9 commits into from Nov 18, 2019

Conversation

@mugmuggy
Copy link
Contributor

mugmuggy commented Oct 7, 2019

Contagious patients can't be treated if they are seeking room.

Adviser says with override was basically truncating the entire list down to the existing first message rather than leaving only the override one.

Broken seek is from #1556 I had identified this. Ward in that instance being the diagnostic room.

The setNextAction when the queue is destroyed would leave patients going from drinks machine to bench, as action_queue_on_change_position gets called from the callback process of action_queue_get_soda. Queue:rerouteAllPatients, wasn't a candidate to flag them as not is_in_queue as this had other artefacts.

Patients appearing to leave is to correct #1233 and related #500, #362, #858 and #650

Staff answering calls to another room, will appear as within the room they are in, and allow patients to enter. If that call was then given to another staff member, they would meander in room (bad for GP) and the patient would normally enter causing a stuck room situation. (#1268)

@mugmuggy mugmuggy mentioned this pull request Oct 7, 2019
@@ -544,7 +544,7 @@ end
@param patient (Patient) the patient we wish to determine if they are static.]]
local function is_static(patient)
local action = patient:getCurrentAction()
return action.name == "queue" or action.name == "idle" or
return action.name == "queue" or action.name == "idle" or action.name == "seek_room" or

This comment has been minimized.

Copy link
@TheCycoONE

TheCycoONE Oct 7, 2019

Member

This list still isn't exhaustive. There must be a better way to indicate whether a patient is currently moving - like annotating each of the actions?

@TheCycoONE TheCycoONE merged commit 7272bd3 into CorsixTH:master Nov 18, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.