[WIP] Use FindLua included in CMake #899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FindLua module included in recent versions of CMake does a better job of locating lua and using consistent versions for the include directories and libraries. In using this module I sacrafice the WITH_LUAJIT flag (not needed), and support for building on x64 OSX with LuaJIT. It is recommended to build against Lua 5.3.
Closed
TheCycoONE
changed the title
|
I see the version of cmake included in travis CI is too old to contain the FindLua module. Given that I will modify the pull request to include the latest version of the upstream FindLua.cmake module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The FindLua module included in recent versions of CMake does a better job of
locating lua and using consistent versions for the include directories and
libraries.
In using this module I sacrafice the WITH_LUAJIT flag (not needed), and support
for building on x64 OSX with LuaJIT. It is recommended to build against Lua 5.3.