Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab crashes when trying to scan after switching to Amazon sign in #47

Closed
ilikecake123 opened this issue Feb 4, 2016 · 3 comments
Closed

Comments

@ilikecake123
Copy link

Hey,
For some reason I switched over to Amazon sign in and after but after I did, the scan / setup button works opens a new tab as expected but after trying to load for a but the background tab crashes (not the browser). Worked fine before but unfortunately I can't switch back to a non-amazon account to test if it's definitely that.

I'm currently using Chrome Version 50.0.2640.0 canary (64-bit) with latest version of the extension if that helps.

@Cortys
Copy link
Owner

Cortys commented Feb 5, 2016

Thanks for the report!

This issue probably isn't related to the Amazon sign in.

It is caused by reactivateDom.js, which replaces window.MutationObserver in order to prevent Comixology from preventing the extension to work properly (hope that made any sense to you). This appears to be a Canary-only bug, causing tab-crashes when performing certain global property manipulations.

I'll release a patch this weekend. A quick fix would be to switch over to stable for now.

@Cortys
Copy link
Owner

Cortys commented Feb 5, 2016

Fixed in 2.3.2.

@Cortys Cortys closed this as completed Feb 5, 2016
@ilikecake123
Copy link
Author

Good work! Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants