Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a issue about the Button click pulse animation! #1040

Closed
lhalcyon opened this issue Feb 27, 2018 · 4 comments
Closed

a issue about the Button click pulse animation! #1040

lhalcyon opened this issue Feb 27, 2018 · 4 comments

Comments

@lhalcyon
Copy link

@lhalcyon lhalcyon commented Feb 27, 2018

There is a problem about button pulse animation and button click event!
the button click sequence in Android
1.button clicked; 2. ripple wave(pulse animation) shows 3.when animation finish,click event responding.
while the button click sequence in Material lib
1.button clicked; 2.ripple wave shows and click event responding.
as a result ,we almost can'see the pulse before a new view controller pushed.

@danieldahan

This comment has been minimized.

Copy link
Member

@danieldahan danieldahan commented Mar 5, 2018

I will take a look into this, do you have a sample project that demonstrates the issue you re facing? Thank you!

@intoxicated

This comment has been minimized.

Copy link
Contributor

@intoxicated intoxicated commented Mar 12, 2018

@danieldahan i'll follow up the issue and will push PR soon

@intoxicated

This comment has been minimized.

Copy link
Contributor

@intoxicated intoxicated commented Mar 12, 2018

I didn't look at the code yet but most likely a solution would be do push viewController in animation completion block

@danieldahan

This comment has been minimized.

Copy link
Member

@danieldahan danieldahan commented Mar 13, 2018

I am closing this issue, if you send a sample project or code block that demonstrates the issue, please reopen this. Thank you!

Open Source automation moved this from to do to in review Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Open Source
  
Done
3 participants
You can’t perform that action at this time.