Don't use yarn, use npm consistently #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The git config should not be needed in the workflow to publish to the repository anyway
We need to make sure all install are done with the same tools, in particular the ones for the publish workflow and SBOM generation to have a consistent result See https://darekkay.com/blog/npm-yarn-dependency-resolution/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might want to move to yarn at some point to be consistent with the other frontend repositories, but at minima we need to be consistent inside this one. In particular, the publish and SBOM generation should be done using the same tool to make sure we report the same dependency tree.