missing correlation.py

[fabianhervaspeters]

Hi I was trying to run sp_validation and got an error saying correlation.py is missing in sp_validation/sp_validation/correlation.py . Now it seems to exist on old branches like "center" and I found that it has been deleted in the master branch at some point but I also saw some changes being made in PR #44 to it at some point so it would be good to resurrect it right before deletion. If it has been deleted on purpose I'd be curious to know how I can have access to the pull request that did it. How do you search for all previous pull requests in which a certain file has been modified?

[martinkilbinger]

This file now lives in the repository shear_psf_leakage. Maybe it is not imported correctly, where does the error occur?

[fabianhervaspeters]

in psf_leakage.ipynb in the notebooks you have the problem coming from:

for sc in ['correlation']:

[martinkilbinger]

Ah ok, I need to change this :-)

[martinkilbinger]

This looks like old code anyway before there was the library...?

Otherwise we would write
from shear_psf_leakage import correlation