Comprehensive catalogue output #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
martinkilbinger
changed the title
create joint comprehensive cat.
…two columns instead of single 2D column
…into out_mask_flags
martinkilbinger
requested review from
cailmdaley
and removed request for
sachaguer
Merged
cailmdaley
approved these changes
Mar 7, 2025
Collaborator
cailmdaley
left a comment
cailmdaley
left a comment
There was a problem hiding this comment.
Looks great Martin! Most of my comments are very minor suggestions that you shouldn't feel any obligation to implement. The only substantive thing is that the run method for run_joint_cat.CalibrateCat is empty, not sure if that was intended.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing an additional master shear catalogue, with all objects before masking and cuts.
This catalogue includes mask flags (pipeline, SExtractor), the number of exposures, and all
metacalibration information for the user to perform calibration (shear and selection response).
Check it out
@sachaguer @cailmdaley