DNM: Maintenance branch - Juno v10.0.2 (Juno V10) #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-frey
changed the title
asalzmann
reviewed
Sep 23, 2022
| AllowMessages: []string{ | ||
| sdk.MsgTypeURL(&banktypes.MsgSend{}), | ||
| sdk.MsgTypeURL(&stakingtypes.MsgDelegate{}), | ||
| sdk.MsgTypeURL(&stakingtypes.MsgUndelegate{}), // this was missed last time |
There was a problem hiding this comment.
Suggested change
| sdk.MsgTypeURL(&stakingtypes.MsgUndelegate{}), // this was missed last time | |
| sdk.MsgTypeURL(&stakingtypes.MsgUndelegate{}), // this was missed last time | |
| sdk.MsgTypeURL(&ibctransfertypes.MsgTransfer{}), |
Would it be possible to allow ICA IBC transfers as well?
For reference, these are the allow messages on the cosmos hub
allow_messages:
- /cosmos.authz.v1beta1.MsgExec
- /cosmos.authz.v1beta1.MsgGrant
- /cosmos.authz.v1beta1.MsgRevoke
- /cosmos.bank.v1beta1.MsgSend
- /cosmos.bank.v1beta1.MsgMultiSend
- /cosmos.distribution.v1beta1.MsgSetWithdrawAddress
- /cosmos.distribution.v1beta1.MsgWithdrawValidatorCommission
- /cosmos.distribution.v1beta1.MsgFundCommunityPool
- /cosmos.distribution.v1beta1.MsgWithdrawDelegatorReward
- /cosmos.feegrant.v1beta1.MsgGrantAllowance
- /cosmos.feegrant.v1beta1.MsgRevokeAllowance
- /cosmos.gov.v1beta1.MsgVoteWeighted
- /cosmos.gov.v1beta1.MsgSubmitProposal
- /cosmos.gov.v1beta1.MsgDeposit
- /cosmos.gov.v1beta1.MsgVote
- /cosmos.staking.v1beta1.MsgEditValidator
- /cosmos.staking.v1beta1.MsgDelegate
- /cosmos.staking.v1beta1.MsgUndelegate
- /cosmos.staking.v1beta1.MsgBeginRedelegate
- /cosmos.staking.v1beta1.MsgCreateValidator
- /cosmos.vesting.v1beta1.MsgCreateVestingAccount
- /ibc.applications.transfer.v1.MsgTransfer
- /tendermint.liquidity.v1beta1.MsgCreatePool
- /tendermint.liquidity.v1beta1.MsgSwapWithinBatch
- /tendermint.liquidity.v1beta1.MsgDepositWithinBatch
- /tendermint.liquidity.v1beta1.MsgWithdrawWithinBatch
There was a problem hiding this comment.
Sorry didn't see this - what's the concrete use case for IBC transfers? Ok with adding it, but might have missed this release now unless there's a burning need.
There was a problem hiding this comment.
For ref, IBC transfers have been added - f2f9de4
the-frey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes an additional change on top of #283 - re-initializing ICA in the upgrade handler to catch a missed SDK message. Thanks to boosik on Discord for spotting that.
Like 283 this is a tagging target and not meant to be merged.