IPv6 support in e.g. Common.php #1089

Closed
leolems opened this Issue Nov 21, 2012 · 3 comments

2 participants

@leolems

Both genoa and sienna.

e.g. stuff like if (!preg_match('#^\d{1,3}.\d{1,3}.\d{1,3}.\d{1,3}$#', $usr['ip']))

@trustmaster
Cotonti member

Surely a must have! Let us know if you notice other places where it relies on IPv4.

@leolems

Agreed.. If i find more references, ill add them here

@trustmaster trustmaster added a commit that referenced this issue Nov 21, 2012
@trustmaster trustmaster Potential fix for #1089. ffea75e
@trustmaster trustmaster added a commit that referenced this issue Nov 21, 2012
@trustmaster trustmaster Potential fix for #1089. 63482d3
@trustmaster
Cotonti member

I've applied a potential fix. It isn't based on inet_pton() because inet_pton() is unsupported on Windows builds of PHP prior to 5.3.0 and it doesn't support some formats of IPv6 addresses.

I can't test it on a IPv6 network though. So it would be great if smb. tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment