This repository has been archived by the owner on Sep 25, 2021. It is now read-only.
update qbittorrent.py for native magnet support #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing solution required the magnet to be converted to a file, which is not necessary - change to support direct magnet integration with qBittorrent which is already natively in the qBittorrent client class library.
|
Thanks for the pull request! Before a real human comes by, please make sure your report has all the below criteria checked
Please make sure you also read contribution guide and followed all the steps. Thanks! |
|
Looks fine to me, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what this fixes:
Existing qBittorrent downloader required magnets to be converted to files, and failed frequently due to torcache availability. Updated downloader to support native magnet downloaders as already supported in the qbittorrent library class.
Never coded in python before - borrowed from working uTorrent downloader for inspiration, feel free to flame me but it works for me locally so thought it best to share.
Related issues:
unable to download files with qBittorrent downloader due to torcache being unavailable.