Skip to content

Ordinals Compatibility#3133

Merged
ouziel-slama merged 44 commits into
developfrom
ordinals
Apr 15, 2025
Merged

Ordinals Compatibility#3133
ouziel-slama merged 44 commits into
developfrom
ordinals

Conversation

@ouziel-slama

@ouziel-slama ouziel-slama commented Apr 10, 2025

Copy link
Copy Markdown
Member
  • Use CBOR encoding format for Sweep, Enhanced Send, Fairminter, Fairmint, Issuance and Broadcast
  • Add mime_type in issuances, fairminters and broadcasts tables
  • Add mime_type parameter for compose_issuance, compose_fairminter and compose_broadcast endpoints
  • Use an envelope script compatible with Ordinals when the description/text of a Fairminter, Issuance or Broadcast is not empty.
  • When using an envelope script compatible with Ordinals, add a dust output to the source address

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft April 10, 2025 12:10
@codecov

codecov Bot commented Apr 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.27626% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.95%. Comparing base (4086feb) to head (4721c42).
Report is 45 commits behind head on develop.

Files with missing lines Patch % Lines
...rty-core/counterpartycore/lib/messages/issuance.py 91.89% 6 Missing ⚠️
...ty-core/counterpartycore/lib/messages/broadcast.py 98.24% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3133      +/-   ##
===========================================
+ Coverage    87.89%   87.95%   +0.05%     
===========================================
  Files          106      106              
  Lines        13900    13973      +73     
===========================================
+ Hits         12218    12290      +72     
- Misses        1682     1683       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread counterparty-core/counterpartycore/lib/api/composer.py Fixed
Comment thread counterparty-core/counterpartycore/lib/messages/fairminter.py Fixed
Comment thread counterparty-core/counterpartycore/lib/messages/issuance.py Fixed
Comment thread counterparty-core/counterpartycore/lib/messages/broadcast.py Fixed
Comment thread counterparty-core/counterpartycore/lib/api/composer.py Fixed

@adamkrellenstein adamkrellenstein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@ouziel-slama ouziel-slama merged commit e560bc3 into develop Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants