Skip to content

Fix course info modal to include H1/Y1 suffix in course title #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
Merged

Fix course info modal to include H1/Y1 suffix in course title #1619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f34a8ac
Fix course info modal to include H1/Y1 suffix in course title
Japleen-Kaur2409 Oct 29, 2025
67e401a
updated the test case to pass the frontend change
Japleen-Kaur2409 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
- Fixed a bug on the generate page where an extraneous info popup would appear when hovering over the top left corner of the graph viewing window
- Fixed a bug that led code to crash when parsing all pre-generated graphs from svg (i.e., program graphs)
- Fixed a bug where redundant boolean nodes were being generated
- Fixed a bug where the course info modal title did not display the H1/Y1 suffix

### 🔧 Internal changes

Expand Down
6 changes: 3 additions & 3 deletions js/components/common/__tests__/CourseModalButtons.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ describe("CourseModal", () => {
// click on the back button, and AAA100H1's modal appears
const backButton = screen.getByText("<")
await user.click(backButton)
modalHeader = screen.getByText("AAA100 Introduction to AAA Thinking")
modalHeader = screen.getByText("AAA100H1 Introduction to AAA Thinking")
expect(modalHeader).toBeDefined()

// click on the forward button, and BBB100's modal appears
Expand All @@ -114,7 +114,7 @@ describe("CourseModal", () => {
// on AAA100
const backButton = screen.getByText("<")
await user.click(backButton)
modalHeader = screen.getByText("AAA100 Introduction to AAA Thinking")
modalHeader = screen.getByText("AAA100H1 Introduction to AAA Thinking")
expect(modalHeader).toBeDefined()

// click on the course link CCC100H1, and CCC100H1's modal opens. The user's
Expand All @@ -129,7 +129,7 @@ describe("CourseModal", () => {
// history of courses looks like: [AAA100, CCC100], with the user currently
// on AAA100
await user.click(backButton)
modalHeader = screen.getByText("AAA100 Introduction to AAA Thinking")
modalHeader = screen.getByText("AAA100H1 Introduction to AAA Thinking")
expect(modalHeader).toBeDefined()

// click on the forward button, and CCC100's modal should open. The user's
Expand Down
2 changes: 1 addition & 1 deletion js/components/common/react_modal.js.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class CourseModal extends React.Component {
this.setState({
course: newCourse,
sessions: sessions,
courseTitle: `${this.state.courseId.toUpperCase()} ${course.title}`,
courseTitle: `${course.name} ${course.title}`,
})
})
}
Expand Down