Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction hash as return value in create/drop #259

Merged
merged 3 commits into from Feb 19, 2019

Conversation

leventeliu
Copy link
Contributor

Now, cql tool can use the returned hash to check transaction status.

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #259 into beta will increase coverage by 0.36%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             beta     #259      +/-   ##
==========================================
+ Coverage   79.01%   79.38%   +0.36%     
==========================================
  Files         159      159              
  Lines       11981    11982       +1     
==========================================
+ Hits         9467     9512      +45     
+ Misses       1829     1779      -50     
- Partials      685      691       +6

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #259 into beta will decrease coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             beta     #259      +/-   ##
==========================================
- Coverage   79.01%   78.75%   -0.26%     
==========================================
  Files         159      159              
  Lines       11981    11982       +1     
==========================================
- Hits         9467     9437      -30     
- Misses       1829     1857      +28     
- Partials      685      688       +3

Copy link
Member

@laodouya laodouya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@leventeliu leventeliu merged commit ec05168 into beta Feb 19, 2019
@leventeliu leventeliu deleted the feature/beta_wait_create_tx branch February 19, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants