Permalink
Browse files

Resolve various issues as per wade's suggestion:

Change of license notice in Makefile.PL

remove use of \"use lib\" in tests that don't need it

remove boilerplate.t
  • Loading branch information...
1 parent 91839fc commit dfd55cf0057133ec2b782766a7ae581780166969 Matt Dees committed Mar 1, 2011
Showing with 1 addition and 60 deletions.
  1. +0 −1 MANIFEST
  2. +1 −1 Makefile.PL
  3. +0 −1 t/01-api-format.t
  4. +0 −1 t/02-construct.t
  5. +0 −1 t/03-api-query.t
  6. +0 −55 t/boilerplate.t
View
@@ -25,7 +25,6 @@ t/00-load.t
t/01-api-format.t
t/02-construct.t
t/03-api-query.t
-t/boilerplate.t
t/lib/PubApiTest.pm
t/manifest.t
t/pod-coverage.t
View
@@ -8,7 +8,7 @@ WriteMakefile(
VERSION_FROM => 'lib/cPanel/PublicAPI.pm',
ABSTRACT_FROM => 'lib/cPanel/PublicAPI.pod',
($ExtUtils::MakeMaker::VERSION >= 6.3002
- ? ('LICENSE'=> 'perl')
+ ? ('LICENSE'=> 'Modified BSD')
: ()),
PL_FILES => {},
PREREQ_PM => {
View
@@ -5,7 +5,6 @@ use warnings;
use Test::More; # last test to print
-use lib 'lib';
use lib 't/lib';
use PubApiTest ();
View
@@ -5,7 +5,6 @@ use warnings;
use Test::More;
-use lib 'lib';
use cPanel::PublicAPI ();
my @getpwuid = getpwuid($>);
View
@@ -5,7 +5,6 @@ use warnings;
use Test::More; # last test to print
-use lib 'lib';
use cPanel::PublicAPI ();
my @getpwuid = getpwuid($>);
View
@@ -1,55 +0,0 @@
-#!perl -T
-
-use strict;
-use warnings;
-use Test::More tests => 3;
-
-sub not_in_file_ok {
- my ($filename, %regex) = @_;
- open( my $fh, '<', $filename )
- or die "couldn't open $filename for reading: $!";
-
- my %violated;
-
- while (my $line = <$fh>) {
- while (my ($desc, $regex) = each %regex) {
- if ($line =~ $regex) {
- push @{$violated{$desc}||=[]}, $.;
- }
- }
- }
-
- if (%violated) {
- fail("$filename contains boilerplate text");
- diag "$_ appears on lines @{$violated{$_}}" for keys %violated;
- } else {
- pass("$filename contains no boilerplate text");
- }
-}
-
-sub module_boilerplate_ok {
- my ($module) = @_;
- not_in_file_ok($module =>
- 'the great new $MODULENAME' => qr/ - The great new /,
- 'boilerplate description' => qr/Quick summary of what the module/,
- 'stub function definition' => qr/function[12]/,
- );
-}
-
-TODO: {
- local $TODO = "Need to replace the boilerplate text";
-
- not_in_file_ok(README =>
- "The README is used..." => qr/The README is used/,
- "'version information here'" => qr/to provide version information/,
- );
-
- not_in_file_ok(Changes =>
- "placeholder date/time" => qr(Date/time)
- );
-
- module_boilerplate_ok('lib/cPanel/PublicAPI.pm');
-
-
-}
-

0 comments on commit dfd55cf

Please sign in to comment.