Distinguish between empty match and non-match#103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 4cb7e30, the matcher inside mapper.cpp broke for the following case:
The first T1 is matched to the empty string:
Then, when the second T1 is matched (
int> & std::vector<std::vector<int>), it goes to the else branch because it believes that the first T1 was never encountered:cpp2rust/cpp2rust/converter/mapper.cpp
Lines 253 to 260 in 1ac73cc
The fix is to replace the captured
std::vector<std::string>withstd::vector<std::optional<std::string>>so that empty matched string can be distinguished from non-matched stirng.