New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The resource compiler should perform at least minimal validation of a manifest prior to embedding #182

Closed
tmwnewbold opened this Issue Feb 27, 2017 · 1 comment

Comments

Projects
4 participants
@tmwnewbold

tmwnewbold commented Feb 27, 2017

The resource compiler should perform at least minimal validation (perhaps simple syntax checking) of JSON manifests prior to embedding them into bundles. At it stands right now, even simple typos in a manifest result in total runtime failure of the product-- see #180. Even when #180 is fixed, it is still extremely wasteful to not be able to detect basic issues with manifest files until runtime.

@saschazelzer

This comment has been minimized.

Member

saschazelzer commented Mar 20, 2017

Very good point, thanks for reporting this.

@saschazelzer saschazelzer added this to Planned in Release 3.1 Mar 20, 2017

@ksubramz ksubramz self-assigned this May 9, 2017

@jeffdiclemente jeffdiclemente removed this from Planned in Release 3.1 May 25, 2017

@jeffdiclemente jeffdiclemente added this to Planned in Release 3.2 Aug 22, 2017

@jeffdiclemente jeffdiclemente moved this from Planned to In Progress in Release 3.2 Aug 29, 2017

@jeffdiclemente jeffdiclemente moved this from In Progress to Planned in Release 3.2 Oct 12, 2017

@jeffdiclemente jeffdiclemente removed this from Planned in Release 3.2 Oct 12, 2017

@jeffdiclemente jeffdiclemente added this to In Progress in Release 3.3 Oct 30, 2017

jeffdiclemente added a commit that referenced this issue Nov 2, 2017

182 bundle manifest validation (#244)
* Add bundle manifest validation

Fixes #182 

Fixed the --compression-level option in usResourceCompiler3 when
compression-level is 0.
Replaced deprecated jsoncpp API calls
Minor re-factor of ResourceCompilerTest.cpp
Add valgrind suppressions for uninitialized values in miniz

Signed-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com

@jeffdiclemente jeffdiclemente moved this from In Progress to Done in Release 3.3 Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment