New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some public/installed headers appear to be unintentional, and some #include non-installed headers #67

Closed
mrlegowatch opened this Issue Dec 21, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@mrlegowatch
Member

mrlegowatch commented Dec 21, 2015

At least five installed headers with the suffix "Private" or "_p", that #include non-installed headers (found under core/src), and therefore can't be used by a client. The specific headers are: usBundleHooks_p.h, usBundlePrivate.h, usFrameworkPrivate.h, usServiceHooks_p.h and usServiseListenerHook_p.h. None of these installed headers appear to be required by any other installed headers. There may be additional private headers being installed as well, which probably shouldn't be installed, to prevent any confusion or inadvertent use by clients.

@saschazelzer saschazelzer added this to the Release 3.0 milestone Feb 17, 2016

@saschazelzer

This comment has been minimized.

Show comment
Hide comment
@saschazelzer

saschazelzer Feb 17, 2016

Member

Thanks for investigating this. Issue #43 is related to a general header cleanup and will fix this issue as well.

Member

saschazelzer commented Feb 17, 2016

Thanks for investigating this. Issue #43 is related to a general header cleanup and will fix this issue as well.

@kevinleeMW

This comment has been minimized.

Show comment
Hide comment
@kevinleeMW

kevinleeMW Aug 10, 2016

Contributor

Pull Request #118 (which addresses issue #43 ) has been merged into development branch.

Contributor

kevinleeMW commented Aug 10, 2016

Pull Request #118 (which addresses issue #43 ) has been merged into development branch.

@kevinleeMW kevinleeMW closed this Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment