New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

144 major version in filenames #168

Merged
merged 10 commits into from Dec 20, 2016

Conversation

Projects
None yet
3 participants
@saschazelzer
Member

saschazelzer commented Nov 18, 2016

This is a PR for issue #144 with the following changes:

Parallel major version installs

  • Executable now have the major version number appended, e.g. usResourceCompiler3 and usShell3
  • Default include install dir is now: ${PREFIX}/CppMicroServices3. E.g. /usr/local/include/cppmicroservices3/cppmicroservices/Bundle.h
  • On Windows, libraries have the major version number appended, e.g. CppMicroServices3.dll (on other platforms, names already contained the full version and symbolic links are set up)

Parallel release/debug installs

  • By default, the debug postfix d is used, e.g. for debug builds on Linux we have libCppMicroServicesd.so.3.0.0, on Windows it is CppMicroServices3d.dll

MinGW support

  • Fixed warnings and errors
  • Added Appveyor MinGW-w64 builds

Other

  • Only build Release configurations on Appveyor to reduce work load
  • Library prefix (e.g. lib) and extensions (.dll etc.) are handled uniformly now via CMake configure_file of GlobalConfig.h.in.
# we need to define a Windows version
set(US_CXX_FLAGS "-D_WIN32_WINNT=0x0500 ${US_CXX_FLAGS}")
# we need to define a Windows version (Windows Vista)
set(US_CXX_FLAGS "-D_WIN32_WINNT=0x0600 -DNTDDI_VERSION=0x06000000 ${US_CXX_FLAGS}")

This comment has been minimized.

@jeffdiclemente

jeffdiclemente Nov 21, 2016

Contributor

any particular reason the minimum is Windows Vista? I thought Windows 7 would be the minimum, based on Microsoft's support.

@jeffdiclemente

jeffdiclemente Nov 21, 2016

Contributor

any particular reason the minimum is Windows Vista? I thought Windows 7 would be the minimum, based on Microsoft's support.

This comment has been minimized.

@saschazelzer

saschazelzer Nov 22, 2016

Member

I was using the lowest version that contained the necessary API to compile the project successfully (unfortunately, I do not remember which part required this). Officially, Windows 7 can still be our minimum supported version.

@saschazelzer

saschazelzer Nov 22, 2016

Member

I was using the lowest version that contained the necessary API to compile the project successfully (unfortunately, I do not remember which part required this). Officially, Windows 7 can still be our minimum supported version.

Show outdated Hide outdated framework/test/SharedLibraryTest.cpp
@@ -35,40 +35,34 @@ int SharedLibraryTest(int /*argc*/, char* /*argv*/[])
US_TEST_BEGIN("SharedLibraryTest");
#ifdef US_PLATFORM_WINDOWS
const std::string LIB_SUFFIX = ".dll";
const char PATH_SEPARATOR = '\\';

This comment has been minimized.

@jeffdiclemente

jeffdiclemente Nov 21, 2016

Contributor

PATH_SEPARATOR could also be removed if DIR_SEP is used from TestingConfig.h.

@jeffdiclemente

jeffdiclemente Nov 21, 2016

Contributor

PATH_SEPARATOR could also be removed if DIR_SEP is used from TestingConfig.h.

This comment has been minimized.

@saschazelzer

saschazelzer Nov 22, 2016

Member

Good catch.

@saschazelzer

saschazelzer Nov 22, 2016

Member

Good catch.

saschazelzer added some commits Dec 14, 2016

Merge remote-tracking branch 'origin/development' into 144-major-vers…
…ion-in-filenames

# Conflicts:
#	framework/src/bundle/BundleUtils.cpp
#	tools/rc/ResourceCompiler.cpp
@saschazelzer

This comment has been minimized.

Show comment
Hide comment
@saschazelzer

saschazelzer Dec 19, 2016

Member

Is anyone having some doubts / comments / opinions about this one?

Member

saschazelzer commented Dec 19, 2016

Is anyone having some doubts / comments / opinions about this one?

@jeffdiclemente

This comment has been minimized.

Show comment
Hide comment
@jeffdiclemente

jeffdiclemente Dec 20, 2016

Contributor

I'm currently reviewing. I will provide feedback/approval today

Contributor

jeffdiclemente commented Dec 20, 2016

I'm currently reviewing. I will provide feedback/approval today

@saschazelzer saschazelzer merged commit 17f7ecb into development Dec 20, 2016

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@saschazelzer saschazelzer deleted the 144-major-version-in-filenames branch Jan 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment