New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov #219

Merged
merged 38 commits into from Jul 17, 2017

Conversation

Projects
None yet
4 participants
@karthikreddy09
Contributor

karthikreddy09 commented Jul 5, 2017

Enable code coverage reports for all branches.
Reports are uploaded to https://codecov.io/gh/cppmicroservices

karthikreddy09 and others added some commits Dec 21, 2016

Experimental changes to enable code coverage report
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Hack to get past build error
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Add a diagnostic message and hard coded path to build dir
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
use the reports directory with codecov tool
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Merge branch 'development'
Conflicts:
	framework/test/SharedLibraryTest.cpp
Enable code coverage only on latest build configurations
Signed-off-by: The Mathworks <Roy.Lurie@mathworks.com>
Revert installing cmake on Mac OS X
Signed-off-by: The Mathworks <Roy.Lurie@mathworks.com>
FIrst attempt to enable code coverage on windows platform
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Remove logging
SIgned-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Fix paths for windows report
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Add Codecov comment for pull requests
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Experiment fixing the paths for windows report
Signed-off-by: The Mathworks <Roy.Lurie@mathworks.com>
Fix AppVeyor YML file
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Re-Enable uploading win coverage file
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Enable previously active nodes for appveyor
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
few more changes
Enable SharedLibraryTest
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Changed flag order in CMakeLists file
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Fixed spaces
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Revert cmake install script and minor changes to yml file
Signed-off-by: The Mathworks Inc ,Roy.Lurie@mathworks.com>
Rearrange statements in appveyor.yml
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Updated comment
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Fixed comment
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
@@ -0,0 +1,67 @@
import xml.etree.ElementTree as xml
import glob, os, re, sys, getopt

This comment has been minimized.

@ksubramz

ksubramz Jul 6, 2017

Contributor

Needn't necessarily address it now but argparse is the idiomatic and the recommended way to do cmdline option parsing (instead of getopt)

@ksubramz

ksubramz Jul 6, 2017

Contributor

Needn't necessarily address it now but argparse is the idiomatic and the recommended way to do cmdline option parsing (instead of getopt)

@jeffdiclemente

There are a number of different variable names used which are all slightly different:

WITH_COVERAGE
US_ENABLE_CCOV
US_COVERAGE_COMMAND
CTEST_COVERAGE_COMMAND
US_CXX_CCOV_FLAGS
US_COVERAGE_ENABLED

Either '''COVERAGE''' or '''CCOV''' is used in the name. It would be easier to maintain and search through the code if all the names stuck to using '''COVERAGE''' or '''CCOV''' or any other name (e.g. '''CODE_COV''') consistently.

Show outdated Hide outdated appveyor.yml
Show outdated Hide outdated CMakeLists.txt
@saschazelzer

Really nice! Is there also a badge that we can add to the readme, linking to the latest report (master and dev branch)?

Show outdated Hide outdated .travis.yml
@@ -0,0 +1,67 @@
import xml.etree.ElementTree as xml

This comment has been minimized.

@saschazelzer

saschazelzer Jul 13, 2017

Member

Could you add a brief high-level description why this file is necessary and how it solves / works around some problem? Is there a known bug report or similar which we can link to?

@saschazelzer

saschazelzer Jul 13, 2017

Member

Could you add a brief high-level description why this file is necessary and how it solves / works around some problem? Is there a known bug report or similar which we can link to?

@@ -0,0 +1,13 @@
@echo off

This comment has been minimized.

@saschazelzer

saschazelzer Jul 13, 2017

Member

Same here, could you briefly describe the purpose of this file inline?

@saschazelzer

saschazelzer Jul 13, 2017

Member

Same here, could you briefly describe the purpose of this file inline?

karthikreddy09 added some commits Jul 14, 2017

Fixes based on review feedback
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Add OpenCppCoverage to path
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Changes to CI files
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Turn ON log messages at the end of batch file
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
CI file changes
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Show outdated Hide outdated appveyor.yml
Show outdated Hide outdated .travis.yml

karthikreddy09 added some commits Jul 15, 2017

Fix typo
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
Fix path setting in appveyor.yml
Signed-off-by: The Mathworks Inc <Roy.Lurie@mathworks.com>
@@ -149,14 +151,23 @@ before_build:
- echo %PATH%
- if "%platform%"=="mingw-w64" set PATH=%PATH:C:\Program Files\Git\usr\bin;=%

This comment has been minimized.

@jeffdiclemente

jeffdiclemente Jul 17, 2017

Contributor

shouldn't this be %PATH%, not %PATH?

also, what does the =% at the end do?

@jeffdiclemente

jeffdiclemente Jul 17, 2017

Contributor

shouldn't this be %PATH%, not %PATH?

also, what does the =% at the end do?

This comment has been minimized.

@saschazelzer

saschazelzer Jul 17, 2017

Member

This is the syntax for Windows batch file string replacements. The line replaces C:\Program Files\Git\usr\bin with the empty string in %PATH%.

@saschazelzer

saschazelzer Jul 17, 2017

Member

This is the syntax for Windows batch file string replacements. The line replaces C:\Program Files\Git\usr\bin with the empty string in %PATH%.

This comment has been minimized.

@karthikreddy09

karthikreddy09 Jul 17, 2017

Contributor

Thanks for the explanation @saschazelzer. I was confused by this as well.

@karthikreddy09

karthikreddy09 Jul 17, 2017

Contributor

Thanks for the explanation @saschazelzer. I was confused by this as well.

@@ -149,14 +151,23 @@ before_build:
- echo %PATH%
- if "%platform%"=="mingw-w64" set PATH=%PATH:C:\Program Files\Git\usr\bin;=%
- if "%platform%"=="mingw-w64" set PATH=C:\msys64\mingw64\bin;%PATH%

This comment has been minimized.

@jeffdiclemente

jeffdiclemente Jul 17, 2017

Contributor

why not combine this with the above line?

@jeffdiclemente

jeffdiclemente Jul 17, 2017

Contributor

why not combine this with the above line?

This comment has been minimized.

@saschazelzer

saschazelzer Jul 17, 2017

Member

The first line does string replacement. The second prepends a new entry to PATH.

@saschazelzer

saschazelzer Jul 17, 2017

Member

The first line does string replacement. The second prepends a new entry to PATH.

This comment has been minimized.

@jeffdiclemente

jeffdiclemente Jul 17, 2017

Contributor

Ok. I see now. Thanks for the explanation.

@jeffdiclemente

jeffdiclemente Jul 17, 2017

Contributor

Ok. I see now. Thanks for the explanation.

@jeffdiclemente

looks good to me.

@karthikreddy09

This comment has been minimized.

Show comment
Hide comment
@karthikreddy09

karthikreddy09 Jul 17, 2017

Contributor

The codecov check failures are expected since there is no existing report for development branch.

Contributor

karthikreddy09 commented Jul 17, 2017

The codecov check failures are expected since there is no existing report for development branch.

@karthikreddy09 karthikreddy09 merged commit 343dc83 into development Jul 17, 2017

3 of 5 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@karthikreddy09 karthikreddy09 deleted the Codecov branch Jul 19, 2017

@karthikreddy09 karthikreddy09 restored the Codecov branch Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment