New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable single-threaded build configuration #239

Merged
merged 2 commits into from Oct 4, 2017

Conversation

Projects
None yet
4 participants
@saschazelzer
Member

saschazelzer commented Sep 7, 2017

No description provided.

@saschazelzer saschazelzer self-assigned this Sep 7, 2017

@saschazelzer saschazelzer requested a review from CppMicroServices/developers Sep 7, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 8, 2017

Codecov Report

Merging #239 into development will decrease coverage by 0.01%.
The diff coverage is 73.07%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #239      +/-   ##
==============================================
- Coverage        77.61%   77.6%   -0.02%     
==============================================
  Files              117     117              
  Lines             7980    8011      +31     
==============================================
+ Hits              6194    6217      +23     
- Misses            1786    1794       +8
Impacted Files Coverage Δ
...ramework/include/cppmicroservices/detail/Threads.h 86.95% <ø> (-1.94%) ⬇️
framework/src/bundle/BundleThread.h 100% <ø> (ø) ⬆️
framework/src/bundle/BundlePrivate.cpp 73.4% <100%> (+0.25%) ⬆️
framework/src/bundle/BundleThread.cpp 73.83% <66.66%> (-1.33%) ⬇️
...rk/include/cppmicroservices/detail/WaitCondition.h 66.66% <0%> (-7.41%) ⬇️
framework/include/cppmicroservices/Any.h 97.1% <0%> (-0.42%) ⬇️
framework/src/bundle/CoreBundleContext.cpp 98.03% <0%> (+0.01%) ⬆️
framework/src/util/FrameworkPrivate.cpp 70.14% <0%> (+0.14%) ⬆️
...mework/src/service/ServiceReferenceBasePrivate.cpp 92.82% <0%> (+1.06%) ⬆️
... and 1 more

codecov-io commented Sep 8, 2017

Codecov Report

Merging #239 into development will decrease coverage by 0.01%.
The diff coverage is 73.07%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #239      +/-   ##
==============================================
- Coverage        77.61%   77.6%   -0.02%     
==============================================
  Files              117     117              
  Lines             7980    8011      +31     
==============================================
+ Hits              6194    6217      +23     
- Misses            1786    1794       +8
Impacted Files Coverage Δ
...ramework/include/cppmicroservices/detail/Threads.h 86.95% <ø> (-1.94%) ⬇️
framework/src/bundle/BundleThread.h 100% <ø> (ø) ⬆️
framework/src/bundle/BundlePrivate.cpp 73.4% <100%> (+0.25%) ⬆️
framework/src/bundle/BundleThread.cpp 73.83% <66.66%> (-1.33%) ⬇️
...rk/include/cppmicroservices/detail/WaitCondition.h 66.66% <0%> (-7.41%) ⬇️
framework/include/cppmicroservices/Any.h 97.1% <0%> (-0.42%) ⬇️
framework/src/bundle/CoreBundleContext.cpp 98.03% <0%> (+0.01%) ⬆️
framework/src/util/FrameworkPrivate.cpp 70.14% <0%> (+0.14%) ⬆️
...mework/src/service/ServiceReferenceBasePrivate.cpp 92.82% <0%> (+1.06%) ⬆️
... and 1 more
std::current_exception()));
}
return tmpres;
#endif
}
bool BundleThread::IsExecutingBundleChanged() const

This comment has been minimized.

@jeffdiclemente

jeffdiclemente Oct 3, 2017

Contributor

Under what circumstances would this function be called?

@jeffdiclemente

jeffdiclemente Oct 3, 2017

Contributor

Under what circumstances would this function be called?

This comment has been minimized.

@saschazelzer

saschazelzer Oct 4, 2017

Member

It seems it isn't. I will remove it later.

@saschazelzer

saschazelzer Oct 4, 2017

Member

It seems it isn't. I will remove it later.

@saschazelzer saschazelzer merged commit 68735a0 into development Oct 4, 2017

4 of 6 checks passed

codecov/patch 73.07% of diff hit (target 77.61%)
Details
codecov/project 77.6% (-0.02%) compared to 843cd2e
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@saschazelzer saschazelzer deleted the single-threading-config branch Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment